-
Notifications
You must be signed in to change notification settings - Fork 29
feat: update spec for v0.7.0 #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
10b8de7 to
3cd3a0d
Compare
3cd3a0d to
34fec34
Compare
540df6f to
f298cfe
Compare
34fec34 to
d6253cd
Compare
f298cfe to
1869bd4
Compare
d6253cd to
894d3e7
Compare
894d3e7 to
c5e9fb3
Compare
adam-alchemy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments!
| **Modular Smart Contract Accounts** **MUST** implement | ||
|
|
||
| - `IAccount` from [ERC-4337](./eip-4337.md). | ||
| - `IAccount.sol` from [ERC-4337](./eip-4337.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice for consistency here, but eventually we should find a way to make this less solidity-specific.
c5e9fb3 to
2ba4978
Compare
9cfac88 to
4338c4d
Compare
adam-alchemy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One tiny nit:
Various updates to the spec and reference implementation interfaces. This builds on the updates that were made in #20.
canSpendNativeTokento clarify that the plugin can spend up to the amount that it sends to the account in the same call even if this value isfalse.PluginManifest'sdependencyInterfaceIdscomment no longer includes hooks.installPlugin's comment on thedependenciesparam is now explicit about eachFunctionReferencebeing a validation function.callbacksSucceededparam of thePluginUninstalledevent toonUninstallSucceeded, as there are no longer multiple callbacks for uninstalls after feat: [v0.7.0] Cut permitted call hooks & injection #20.pluginInitDataparam ofinstallPlugintopluginInstallDatato be more consistent with thepluginUninstallDataparam ofuninstallPlugin.FunctionReferencetype declaration has been moved fromIAccountLoupe.soltoIPluginManager.sol, since the former is an optional interface.installPluginupdates:interfaceIds, which was implied but missing.PluginInstallevent, which was implied but missing.uninstallPluginupdates:PluginUninstalledevent, which was implied but missing.