feat: [v0.7.0] Cut permitted call hooks & injection #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-alchemy
force-pushed
the
adam/experiment-cut-permitted-call-hooks
branch
from
6e79261 to
2eb0877
Compare
jaypaik
approved these changes
Dec 15, 2023
jaypaik
force-pushed
the
v0.7.0-develop
branch
from
d404df2 to
193d529
Compare
adam-alchemy
force-pushed
the
adam/experiment-cut-permitted-call-hooks
branch
from
97a2741 to
a79c252
Compare
adam-alchemy
changed the title
jaypaik
force-pushed
the
adam/experiment-cut-permitted-call-hooks
branch
from
84e75cb to
50b6407
Compare
jaypaik
force-pushed
the
adam/experiment-cut-permitted-call-hooks
branch
from
50b6407 to
272d301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: erc6900/resources#22
Motivation
The use case for permitted call hooks is enforcing permissions in a way that better reuses plugins. However, the case where this makes a difference is pretty far out, since it requires 3 or more plugins attached to the same selector. You can almost fully replicate its functionality with regular hooks attached to non-installed selectors then installing it after.
Solution
Remove permitted call hooks from the manifest, install paths, execution paths, loupe paths, and the ERC.