Skip to content

Conversation

@jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Oct 7, 2024

  • Move libraries under libraries/, separate from helpers/
  • Move test files accordingly
  • Move modules under folders within their respective categories

@jaypaik jaypaik requested a review from a team October 7, 2024 21:30
@jaypaik jaypaik force-pushed the 10-07-refactor_organize_files branch from 64b4bfa to 7cc3457 Compare October 7, 2024 21:35
Base automatically changed from 10-07-refactor_fix_ERC20TokenLimitModule_and_remove_dependency_on_modular-account-libs to develop October 8, 2024 19:01
@jaypaik jaypaik force-pushed the 10-07-refactor_organize_files branch from 7cc3457 to 5b69346 Compare October 8, 2024 19:01
@octane-security-app
Copy link

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • DeployAllowlistModule.s.sol: The smart contract updated the import path for AllowlistModule to a new directory structure.
  • AccountFactory.sol: Updated import path for ValidationConfigLib from helpers to libraries.
  • ModularAccountView.sol: The smart contract revision primarily involves relocating HookConfigLib from the "helpers" directory to the "libraries" directory.
  • ModuleManagerInternals.sol: The updates involve shifting several library imports to a new "libraries" directory and updating function calls accordingly.
  • ReferenceModularAccount.sol: The smart contract imports are reorganized, moving several helper libraries to a new 'libraries' directory.
  • SemiModularAccount.sol: The smart contract update involves moving ModuleEntityLib from a helpers directory to a libraries directory.

🔗 Commit Hash: 5b69346

@octane-security-app

This comment was marked as resolved.

@jaypaik jaypaik merged commit 14f1f89 into develop Oct 8, 2024
4 checks passed
@jaypaik jaypaik deleted the 10-07-refactor_organize_files branch October 8, 2024 19:12
jaypaik added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants