Skip to content

Commit 64b4bfa

Browse files
committed
refactor: organize files
1 parent a2bd984 commit 64b4bfa

39 files changed

+108
-100
lines changed

script/DeployAllowlistModule.s.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {Script, console} from "forge-std/Script.sol";
55

66
import {Create2} from "@openzeppelin/contracts/utils/Create2.sol";
77

8-
import {AllowlistModule} from "../src/modules/permissionhooks/AllowlistModule.sol";
8+
import {AllowlistModule} from "../src/modules/permissions/AllowlistModule.sol";
99

1010
contract DeployAllowlistModuleScript is Script {
1111
address public allowlistModule = vm.envOr("ALLOWLIST_MODULE", address(0));

src/account/AccountFactory.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {Create2} from "@openzeppelin/contracts/utils/Create2.sol";
99

1010
import {ReferenceModularAccount} from "../account/ReferenceModularAccount.sol";
1111
import {SemiModularAccount} from "../account/SemiModularAccount.sol";
12-
import {ValidationConfigLib} from "../helpers/ValidationConfigLib.sol";
12+
import {ValidationConfigLib} from "../libraries/ValidationConfigLib.sol";
1313

1414
import {LibClone} from "solady/utils/LibClone.sol";
1515

src/account/ModularAccountView.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import {UUPSUpgradeable} from "@openzeppelin/contracts/proxy/utils/UUPSUpgradeab
55
import {EnumerableMap} from "@openzeppelin/contracts/utils/structs/EnumerableMap.sol";
66
import {EnumerableSet} from "@openzeppelin/contracts/utils/structs/EnumerableSet.sol";
77

8-
import {HookConfigLib} from "../helpers/HookConfigLib.sol";
98
import {HookConfig, IModularAccount, ModuleEntity} from "../interfaces/IModularAccount.sol";
109
import {ExecutionDataView, IModularAccountView, ValidationDataView} from "../interfaces/IModularAccountView.sol";
10+
import {HookConfigLib} from "../libraries/HookConfigLib.sol";
1111
import {ExecutionData, ValidationData, getAccountStorage, toHookConfig} from "./AccountStorage.sol";
1212

1313
abstract contract ModularAccountView is IModularAccountView {

src/account/ModuleManagerInternals.sol

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@ import {EnumerableSet} from "@openzeppelin/contracts/utils/structs/EnumerableSet
66

77
import {collectReturnData} from "../helpers/CollectReturnData.sol";
88
import {MAX_PRE_VALIDATION_HOOKS} from "../helpers/Constants.sol";
9-
import {HookConfigLib} from "../helpers/HookConfigLib.sol";
10-
import {KnownSelectors} from "../helpers/KnownSelectors.sol";
11-
import {ModuleEntityLib} from "../helpers/ModuleEntityLib.sol";
12-
import {ValidationConfigLib} from "../helpers/ValidationConfigLib.sol";
139
import {IExecutionHookModule} from "../interfaces/IExecutionHookModule.sol";
1410
import {ExecutionManifest, ManifestExecutionHook} from "../interfaces/IExecutionModule.sol";
1511
import {HookConfig, IModularAccount, ModuleEntity, ValidationConfig} from "../interfaces/IModularAccount.sol";
1612
import {IModule} from "../interfaces/IModule.sol";
1713
import {IValidationHookModule} from "../interfaces/IValidationHookModule.sol";
1814
import {IValidationModule} from "../interfaces/IValidationModule.sol";
15+
import {HookConfigLib} from "../libraries/HookConfigLib.sol";
16+
import {KnownSelectorsLib} from "../libraries/KnownSelectorsLib.sol";
17+
import {ModuleEntityLib} from "../libraries/ModuleEntityLib.sol";
18+
import {ValidationConfigLib} from "../libraries/ValidationConfigLib.sol";
1919

2020
import {
2121
AccountStorage,
@@ -61,12 +61,12 @@ abstract contract ModuleManagerInternals is IModularAccount {
6161

6262
// Make sure incoming execution function does not collide with any native functions (data are stored on the
6363
// account implementation contract)
64-
if (KnownSelectors.isNativeFunction(selector)) {
64+
if (KnownSelectorsLib.isNativeFunction(selector)) {
6565
revert NativeFunctionNotAllowed(selector);
6666
}
6767

6868
// Make sure incoming execution function is not a function in IModule
69-
if (KnownSelectors.isIModuleFunction(selector)) {
69+
if (KnownSelectorsLib.isIModuleFunction(selector)) {
7070
revert IModuleFunctionNotAllowed(selector);
7171
}
7272

@@ -75,7 +75,7 @@ abstract contract ModuleManagerInternals is IModularAccount {
7575
// sneaking in a function with the same selector as e.g.
7676
// `validatePaymasterUserOp` and turning the account into their own
7777
// personal paymaster.
78-
if (KnownSelectors.isErc4337Function(selector)) {
78+
if (KnownSelectorsLib.isErc4337Function(selector)) {
7979
revert Erc4337FunctionNotAllowed(selector);
8080
}
8181

src/account/ReferenceModularAccount.sol

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,17 @@ import {EnumerableSet} from "@openzeppelin/contracts/utils/structs/EnumerableSet
1313

1414
import {collectReturnData} from "../helpers/CollectReturnData.sol";
1515
import {DIRECT_CALL_VALIDATION_ENTITYID} from "../helpers/Constants.sol";
16-
import {HookConfig, HookConfigLib} from "../helpers/HookConfigLib.sol";
17-
import {ModuleEntityLib} from "../helpers/ModuleEntityLib.sol";
18-
import {SparseCalldataSegmentLib} from "../helpers/SparseCalldataSegmentLib.sol";
19-
import {ValidationConfigLib} from "../helpers/ValidationConfigLib.sol";
16+
2017
import {_coalescePreValidation, _coalesceValidation} from "../helpers/ValidationResHelpers.sol";
2118
import {IExecutionHookModule} from "../interfaces/IExecutionHookModule.sol";
2219
import {ExecutionManifest} from "../interfaces/IExecutionModule.sol";
2320
import {Call, IModularAccount, ModuleEntity, ValidationConfig} from "../interfaces/IModularAccount.sol";
2421
import {IValidationHookModule} from "../interfaces/IValidationHookModule.sol";
2522
import {IValidationModule} from "../interfaces/IValidationModule.sol";
23+
import {HookConfig, HookConfigLib} from "../libraries/HookConfigLib.sol";
24+
import {ModuleEntityLib} from "../libraries/ModuleEntityLib.sol";
25+
import {SparseCalldataSegmentLib} from "../libraries/SparseCalldataSegmentLib.sol";
26+
import {ValidationConfigLib} from "../libraries/ValidationConfigLib.sol";
2627
import {AccountExecutor} from "./AccountExecutor.sol";
2728
import {AccountStorage, getAccountStorage, toHookConfig, toSetValue} from "./AccountStorage.sol";
2829
import {AccountStorageInitializable} from "./AccountStorageInitializable.sol";

src/account/SemiModularAccount.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {ReferenceModularAccount} from "./ReferenceModularAccount.sol";
55
import {IEntryPoint} from "@eth-infinitism/account-abstraction/interfaces/IEntryPoint.sol";
66
import {PackedUserOperation} from "@eth-infinitism/account-abstraction/interfaces/PackedUserOperation.sol";
77

8-
import {ModuleEntityLib} from "../helpers/ModuleEntityLib.sol";
8+
import {ModuleEntityLib} from "../libraries/ModuleEntityLib.sol";
99

1010
import {IModularAccount, ModuleEntity, ValidationConfig} from "../interfaces/IModularAccount.sol";
1111

File renamed without changes.

src/helpers/KnownSelectors.sol renamed to src/libraries/KnownSelectorsLib.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {IValidationModule} from "../interfaces/IValidationModule.sol";
1717

1818
/// @dev Library to help to check if a selector is a know function selector of the modular account or ERC-4337
1919
/// contract.
20-
library KnownSelectors {
20+
library KnownSelectorsLib {
2121
function isNativeFunction(bytes4 selector) internal pure returns (bool) {
2222
return
2323
// check against IAccount methods
File renamed without changes.

src/helpers/SparseCalldataSegmentLib.sol renamed to src/libraries/SparseCalldataSegmentLib.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SPDX-License-Identifier: GPL-3.0
22
pragma solidity ^0.8.20;
33

4-
import {RESERVED_VALIDATION_DATA_INDEX} from "./Constants.sol";
4+
import {RESERVED_VALIDATION_DATA_INDEX} from "../helpers/Constants.sol";
55

66
/// @title Sparse Calldata Segment Library
77
/// @notice Library for working with sparsely-packed calldata segments, identified with an index.

0 commit comments

Comments
 (0)