[DRAFT] SMA 2: Hardcoded Single Signer #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: fangting-alchemy <[email protected]>
…w multiple validation installation on account (#93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a followup to #119, where instead of appending a validation to bytecode, we hardcode single-signer functionality into the account, effectively cutting down on initialization cost by introducing a simple one-address initializer.
Solution
Implement a built-in fallback single-signer validation. This is a global validation, and disabling it is akin to setting the fallback signer to the zero address.
To use the fallback validation, pass a validation equivalent to
bytes24(max).Adding hooks to the fallback validation is an issue still being investigated, although it is treated mostly as a normal validation, we might only need to add a bit of branching in
installValidation()if this ends up being the optimal route for SMA.This solution saves on bytecode deployment cost, but still requires an initializer, and adds to implementation bytecode.