feat: [v0.8-develop] Remove validation installation from the manifest 3/N #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamegyed
changed the title
adamegyed
force-pushed
the
adam/merge-plugin-manager
branch
from
220497a to
2a5de9d
Compare
adamegyed
force-pushed
the
adam/manifest-remove-validation
branch
from
4efbaef to
610a6fc
Compare
adamegyed
changed the title
| _setExecutionFunction(selector, isPublic, allowGlobalValidation, module); | ||
| } | ||
|
|
||
| length = manifest.validationFunctions.length; |
Collaborator
There was a problem hiding this comment.
Did we get rid of preValidationHooks installation in installModule in a previous PR? Don't see them in code anymore.
Contributor
Author
There was a problem hiding this comment.
We did, I think in the PR that introduced installValidation. Previously, preValidationHooks were associated with selectors, which also associated them to validations because there was a 1:1 mapping between selectors and validation. But when we allowed multiple validation functions, we needed a way to associate the preValidationHooks, so they became installValidation only.
adamegyed
force-pushed
the
adam/merge-plugin-manager
branch
from
2a5de9d to
1ba0233
Compare
adamegyed
force-pushed
the
adam/manifest-remove-validation
branch
from
04132e0 to
22f26cf
Compare
fangting-alchemy
approved these changes
Jul 23, 2024
adamegyed
added a commit
that referenced
this pull request
Jul 26, 2024
adamegyed
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As noted in #103, since the introduction of
installValidation, there have been two pathways of installing validation functions: by specifying them ininstallValidation, or by having a plugin specifying them in the manifest and callinginstallPlugin.Given the context that most uses of validation-in-manifest installs was for direct call authorization, and the context that adding pre-validation hooks + permission hooks to the manifest based install is not very direct, this PR explores an option of removing validation installation from the manifest completely.
Solution
Remove validation functions from the manifest.
Update any usages of direct call validation specified in the manifest to an initialization of the direct call permission via
installValidation.Future Work
If we decide to go this route, we should define a place in the plugin metadata to indicate a request for direct call permissions.