-
Notifications
You must be signed in to change notification settings - Fork 496
Master #2505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
달고나 제어보드 디지털, 아날로그 블록 생성
issue/6258
블럭 종류 구분을 위한 타이틀 추가
hardwareMonitor 이미지 변경
네오캐논 교구 신규 등록
공유보드 업데이트 2305
[네오피아] 버그 수정
230512_딜레이시간 변경
글자 및 선 구분 수정, 최종 PR
issue/5866
[HW][4.23.0] 하드웨어 버전업 PR
| } | ||
| this.pendingResponseList[blockId] = 'executed'; | ||
| const command = this.makeCommandExt2(blockId, type, params); | ||
| if (!command) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| break; | ||
| } | ||
| if (input === 'IN12') { | ||
| const sensor1 = sensorData['in1Values'][0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["in1Values"] is better written in dot notation.
| const sensor1 = sensorData['in1Values'][0]; | |
| const sensor1 = sensorData.in1Values[0]; |
| } | ||
| if (input === 'IN12') { | ||
| const sensor1 = sensorData['in1Values'][0]; | ||
| const sensor2 = sensorData['in2Values'][0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["in2Values"] is better written in dot notation.
| const sensor2 = sensorData['in2Values'][0]; | |
| const sensor2 = sensorData.in2Values[0]; |
| return sensor1 === 200 && sensor2 === 200; | ||
| } | ||
| } else if (input === 'IN123') { | ||
| const sensor1 = sensorData['in1Values'][0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["in1Values"] is better written in dot notation.
| const sensor1 = sensorData['in1Values'][0]; | |
| const sensor1 = sensorData.in1Values[0]; |
| } | ||
| } else if (input === 'IN123') { | ||
| const sensor1 = sensorData['in1Values'][0]; | ||
| const sensor2 = sensorData['in2Values'][0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["in2Values"] is better written in dot notation.
| const sensor2 = sensorData['in2Values'][0]; | |
| const sensor2 = sensorData.in2Values[0]; |
|
|
||
| onReceivePdu(pdu) { | ||
| if (pdu[0] === HEADER[0] && pdu[1] === HEADER[1]) { | ||
| this.localBuffer['IN1'] = pdu[2]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["IN1"] is better written in dot notation.
| this.localBuffer['IN1'] = pdu[2]; | |
| this.localBuffer.IN1 = pdu[2]; |
| onReceivePdu(pdu) { | ||
| if (pdu[0] === HEADER[0] && pdu[1] === HEADER[1]) { | ||
| this.localBuffer['IN1'] = pdu[2]; | ||
| this.localBuffer['IN2'] = pdu[3]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["IN2"] is better written in dot notation.
| this.localBuffer['IN2'] = pdu[3]; | |
| this.localBuffer.IN2 = pdu[3]; |
| if (pdu[0] === HEADER[0] && pdu[1] === HEADER[1]) { | ||
| this.localBuffer['IN1'] = pdu[2]; | ||
| this.localBuffer['IN2'] = pdu[3]; | ||
| this.localBuffer['IN3'] = pdu[4]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["IN3"] is better written in dot notation.
| this.localBuffer['IN3'] = pdu[4]; | |
| this.localBuffer.IN3 = pdu[4]; |
| this.localBuffer['IN1'] = pdu[2]; | ||
| this.localBuffer['IN2'] = pdu[3]; | ||
| this.localBuffer['IN3'] = pdu[4]; | ||
| this.localBuffer['IR'] = pdu[5]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["IR"] is better written in dot notation.
| this.localBuffer['IR'] = pdu[5]; | |
| this.localBuffer.IR = pdu[5]; |
| this.localBuffer['IN2'] = pdu[3]; | ||
| this.localBuffer['IN3'] = pdu[4]; | ||
| this.localBuffer['IR'] = pdu[5]; | ||
| this.localBuffer['BAT'] = pdu[6]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["BAT"] is better written in dot notation.
| this.localBuffer['BAT'] = pdu[6]; | |
| this.localBuffer.BAT = pdu[6]; |
4.25.0