Skip to content

Conversation

@leunge
Copy link
Contributor

@leunge leunge commented May 24, 2023

4.25.0

dalgona-edu and others added 30 commits April 6, 2023 17:16
잘못된 파일
잘못된 파일
도트매트릭스 코드 수정 온도 블록 추가 변환 블록추가
하드웨어 이미지 변경, 블록 추가 및 수정
This reverts commit dd1af62.
This reverts commit 1c31346.
Tnks2U and others added 21 commits May 11, 2023 10:57
달고나 제어보드 디지털, 아날로그 블록 생성
LCD 이미지를 명칭으로 변경
모터/로봇 정지를 Response 기다리게 변경
블럭 종류 구분을 위한 타이틀 추가
LCD 이미지를 명칭으로 변경
모터/로봇 정지를 Response 기다리게 변경
네오캐논 교구 신규 등록
공유보드 업데이트 2305
230512_딜레이시간 변경
글자 및 선 구분 수정, 최종 PR
[HW][4.23.0] 하드웨어 버전업 PR
@leunge leunge merged commit c6d7852 into master May 24, 2023
}
this.pendingResponseList[blockId] = 'executed';
const command = this.makeCommandExt2(blockId, type, params);
if (!command) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.

Suggested change
if (!command) return;
if (!command) {return;}

break;
}
if (input === 'IN12') {
const sensor1 = sensorData['in1Values'][0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in1Values"] is better written in dot notation.

Suggested change
const sensor1 = sensorData['in1Values'][0];
const sensor1 = sensorData.in1Values[0];

}
if (input === 'IN12') {
const sensor1 = sensorData['in1Values'][0];
const sensor2 = sensorData['in2Values'][0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in2Values"] is better written in dot notation.

Suggested change
const sensor2 = sensorData['in2Values'][0];
const sensor2 = sensorData.in2Values[0];

return sensor1 === 200 && sensor2 === 200;
}
} else if (input === 'IN123') {
const sensor1 = sensorData['in1Values'][0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in1Values"] is better written in dot notation.

Suggested change
const sensor1 = sensorData['in1Values'][0];
const sensor1 = sensorData.in1Values[0];

}
} else if (input === 'IN123') {
const sensor1 = sensorData['in1Values'][0];
const sensor2 = sensorData['in2Values'][0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in2Values"] is better written in dot notation.

Suggested change
const sensor2 = sensorData['in2Values'][0];
const sensor2 = sensorData.in2Values[0];


onReceivePdu(pdu) {
if (pdu[0] === HEADER[0] && pdu[1] === HEADER[1]) {
this.localBuffer['IN1'] = pdu[2];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["IN1"] is better written in dot notation.

Suggested change
this.localBuffer['IN1'] = pdu[2];
this.localBuffer.IN1 = pdu[2];

onReceivePdu(pdu) {
if (pdu[0] === HEADER[0] && pdu[1] === HEADER[1]) {
this.localBuffer['IN1'] = pdu[2];
this.localBuffer['IN2'] = pdu[3];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["IN2"] is better written in dot notation.

Suggested change
this.localBuffer['IN2'] = pdu[3];
this.localBuffer.IN2 = pdu[3];

if (pdu[0] === HEADER[0] && pdu[1] === HEADER[1]) {
this.localBuffer['IN1'] = pdu[2];
this.localBuffer['IN2'] = pdu[3];
this.localBuffer['IN3'] = pdu[4];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["IN3"] is better written in dot notation.

Suggested change
this.localBuffer['IN3'] = pdu[4];
this.localBuffer.IN3 = pdu[4];

this.localBuffer['IN1'] = pdu[2];
this.localBuffer['IN2'] = pdu[3];
this.localBuffer['IN3'] = pdu[4];
this.localBuffer['IR'] = pdu[5];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["IR"] is better written in dot notation.

Suggested change
this.localBuffer['IR'] = pdu[5];
this.localBuffer.IR = pdu[5];

this.localBuffer['IN2'] = pdu[3];
this.localBuffer['IN3'] = pdu[4];
this.localBuffer['IR'] = pdu[5];
this.localBuffer['BAT'] = pdu[6];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["BAT"] is better written in dot notation.

Suggested change
this.localBuffer['BAT'] = pdu[6];
this.localBuffer.BAT = pdu[6];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants