[HW][4.23.0] 하드웨어 버전업 PR #2504
[HW][4.23.0] 하드웨어 버전업 PR #2504
Conversation
Tnks2U
commented
May 24, 2023
Tnks2U
commented
- https://oss.navercorp.com/entry/entry2/issues/6368
달고나 제어보드 디지털, 아날로그 블록 생성
블럭 종류 구분을 위한 타이틀 추가
hardwareMonitor 이미지 변경
네오캐논 교구 신규 등록
공유보드 업데이트 2305
[네오피아] 버그 수정
230512_딜레이시간 변경
글자 및 선 구분 수정, 최종 PR
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| this.pendingResponseList[blockId] = 'executed'; | ||
| const command = this.makeCommandExt2(blockId, type, params); | ||
| if (!command) return; |
| break; | ||
| } | ||
| if (input === 'IN12') { | ||
| const sensor1 = sensorData['in1Values'][0]; |
There was a problem hiding this comment.
["in1Values"] is better written in dot notation.
| const sensor1 = sensorData['in1Values'][0]; | |
| const sensor1 = sensorData.in1Values[0]; |
| } | ||
| if (input === 'IN12') { | ||
| const sensor1 = sensorData['in1Values'][0]; | ||
| const sensor2 = sensorData['in2Values'][0]; |
There was a problem hiding this comment.
["in2Values"] is better written in dot notation.
| const sensor2 = sensorData['in2Values'][0]; | |
| const sensor2 = sensorData.in2Values[0]; |
| return sensor1 === 200 && sensor2 === 200; | ||
| } | ||
| } else if (input === 'IN123') { | ||
| const sensor1 = sensorData['in1Values'][0]; |
There was a problem hiding this comment.
["in1Values"] is better written in dot notation.
| const sensor1 = sensorData['in1Values'][0]; | |
| const sensor1 = sensorData.in1Values[0]; |
| } | ||
| } else if (input === 'IN123') { | ||
| const sensor1 = sensorData['in1Values'][0]; | ||
| const sensor2 = sensorData['in2Values'][0]; |
There was a problem hiding this comment.
["in2Values"] is better written in dot notation.
| const sensor2 = sensorData['in2Values'][0]; | |
| const sensor2 = sensorData.in2Values[0]; |
|
|
||
| onReceivePdu(pdu) { | ||
| if (pdu[0] === HEADER[0] && pdu[1] === HEADER[1]) { | ||
| this.localBuffer['IN1'] = pdu[2]; |
There was a problem hiding this comment.
["IN1"] is better written in dot notation.
| this.localBuffer['IN1'] = pdu[2]; | |
| this.localBuffer.IN1 = pdu[2]; |
| onReceivePdu(pdu) { | ||
| if (pdu[0] === HEADER[0] && pdu[1] === HEADER[1]) { | ||
| this.localBuffer['IN1'] = pdu[2]; | ||
| this.localBuffer['IN2'] = pdu[3]; |
There was a problem hiding this comment.
["IN2"] is better written in dot notation.
| this.localBuffer['IN2'] = pdu[3]; | |
| this.localBuffer.IN2 = pdu[3]; |
| if (pdu[0] === HEADER[0] && pdu[1] === HEADER[1]) { | ||
| this.localBuffer['IN1'] = pdu[2]; | ||
| this.localBuffer['IN2'] = pdu[3]; | ||
| this.localBuffer['IN3'] = pdu[4]; |
There was a problem hiding this comment.
["IN3"] is better written in dot notation.
| this.localBuffer['IN3'] = pdu[4]; | |
| this.localBuffer.IN3 = pdu[4]; |
| this.localBuffer['IN1'] = pdu[2]; | ||
| this.localBuffer['IN2'] = pdu[3]; | ||
| this.localBuffer['IN3'] = pdu[4]; | ||
| this.localBuffer['IR'] = pdu[5]; |
There was a problem hiding this comment.
["IR"] is better written in dot notation.
| this.localBuffer['IR'] = pdu[5]; | |
| this.localBuffer.IR = pdu[5]; |
| this.localBuffer['IN2'] = pdu[3]; | ||
| this.localBuffer['IN3'] = pdu[4]; | ||
| this.localBuffer['IR'] = pdu[5]; | ||
| this.localBuffer['BAT'] = pdu[6]; |
There was a problem hiding this comment.
["BAT"] is better written in dot notation.
| this.localBuffer['BAT'] = pdu[6]; | |
| this.localBuffer.BAT = pdu[6]; |
