Skip to content

[4.24.0] 하드웨어 1.9.41 PR #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 25, 2023
Merged

[4.24.0] 하드웨어 1.9.41 PR #2486

merged 20 commits into from
Apr 25, 2023

Conversation

@Tnks2U
Copy link
Collaborator

@Tnks2U Tnks2U commented Apr 21, 2023

Yejin715 and others added 15 commits March 21, 2023 21:49
@Yejin715
[20230321]Remove the Buzzer Time Off Code
009a63b
@RoboroboLab
Dotmatrix 블록 형태 변경
60254e2
@pyocoding
표쌤코딩 기능추가
3e88a95 
도트매트릭스 및 변환 블록추가
@Tnks2U
Merge pull request #2478 from entrylabs/develop
823fb54 
develop-hw 최신화
@jinirobot1
AIBOT 제어 블록 추가
e23904a
@entrydev
쪼코 블럭의 브라우저로 연결하기 기능 추가
3f0d704
@SketchwareMoon
신규 하드웨어 네오(NEO) 추가
95f6ea5
@Tnks2U
Merge pull request #2484 from SketchwareMoon/develop-hw
1558968 
[네오피아] 하드웨어 추가
@Tnks2U
Merge pull request #2472 from RoboroboLab/develop-hw
c7835d0 
Dotmatrix 블록 형태 변경
@Tnks2U
Merge pull request #2475 from pyocoding/develop-hw
47d1d93 
표쌤코딩 기능추가
@Tnks2U
Merge pull request #2470 from Yejin715/develop-hw
8e1bb67 
[20230321]Remove the Buzzer Time Off Code
@Tnks2U
Merge pull request #2480 from jinirobot1/develop
b7db649 
AIBOT 제어 블록 추가
@Tnks2U
Merge pull request #2481 from tyranno/develop-hw
3956f76 
쪼코 블럭의 브라우저로 연결하기 기능 추가
@Tnks2U
fix: 코알라보드 모니터템플릿 다국어 변경
ffc3dad
@Tnks2U
refactor: 코알라보드 lint 적용
05dc798
@Tnks2U Tnks2U self-assigned this Apr 21, 2023
github-actions[bot]
github-actions bot reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

src/playground/blocks/hardwareLite/block_neo_lite.js|2623 col 93| Replace output,·direction,·speed with ⏎····································output,⏎····································direction,⏎····································speed,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|2625 col 1| This line has a length of 116. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|2625 col 90| Replace output,·direction,·speed with ⏎····································output,⏎····································direction,⏎····································speed,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|2778 col 1| This line has a length of 105. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|2778 col 98| Replace speed with ⏎····································speed,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|2780 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|2780 col 95| Replace speed with ⏎····································speed,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|2792 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|3011 col 1| This line has a length of 106. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|3011 col 99| Replace speed with ⏎····································speed,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|3013 col 1| This line has a length of 103. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|3013 col 96| Replace speed with ⏎····································speed,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|3025 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|3113 col 1| This line has a length of 105. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|3113 col 56| Replace blockId,·NeoBlockType.AUTO_DRIVING_SENSOR_START,·[ with ⏎····································blockId,⏎····································NeoBlockType.AUTO_DRIVING_SENSOR_START,
src/playground/blocks/hardwareLite/block_neo_lite.js|3114 col 37| Replace sensor, with [sensor,·speed]
src/playground/blocks/hardwareLite/block_neo_lite.js|3115 col 33| Replace ····speed, with );
src/playground/blocks/hardwareLite/block_neo_lite.js|3116 col 29| Replace ····]);⏎····························}·else·{ with }·else·{⏎································this.requestCommand(
src/playground/blocks/hardwareLite/block_neo_lite.js|3118 col 1| This line has a length of 118. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|3118 col 33| Replace this.requestCommand(blockId,·NeoBlockType.AUTO_DRIVING_SENSOR_START,·[sensor,·speed] with ····blockId,⏎····································NeoBlockType.AUTO_DRIVING_SENSOR_START,⏎····································[sensor,·speed]⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|3309 col 47| Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.
src/playground/blocks/hardwareLite/block_neo_lite.js|3347 col 47| Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.
src/playground/blocks/hardwareLite/block_neo_lite.js|3435 col 47| Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.
src/playground/blocks/hardwareLite/block_neo_lite.js|3473 col 47| Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.
src/playground/blocks/hardwareLite/block_neo_lite.js|3584 col 1| This line has a length of 107. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|3584 col 87| Replace output,·brightness with ⏎····································output,⏎····································brightness,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|3586 col 1| This line has a length of 104. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|3586 col 84| Replace output,·brightness with ⏎····································output,⏎····································brightness,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|3598 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|3689 col 1| This line has a length of 103. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|3689 col 83| Replace output,·speed,·100 with ⏎································output,⏎································speed,⏎································100,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|3700 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|3860 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|3860 col 86| Replace output,·color with ⏎································output,⏎································color,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|3871 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|4001 col 1| This line has a length of 111. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4001 col 96| Replace output,·input with ⏎································output,⏎································input,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|4160 col 1| This line has a length of 106. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4160 col 91| Replace output,·value with ⏎····································output,⏎····································value,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|4162 col 1| This line has a length of 103. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4162 col 88| Replace output,·value with ⏎····································output,⏎····································value,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|4174 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|4257 col 51| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4259 col 51| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4261 col 51| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4316 col 51| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4318 col 51| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4320 col 51| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4399 col 52| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4402 col 52| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4405 col 52| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4493 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4494 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4507 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4508 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4509 col 56| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4525 col 62| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4528 col 62| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4531 col 62| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4630 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4631 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4658 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4659 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4660 col 56| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4663 col 1| This line has a length of 105. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4663 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4669 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4669 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4671 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4671 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4675 col 1| This line has a length of 105. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4675 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4681 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4681 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4683 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4683 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4690 col 62| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4693 col 62| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4696 col 62| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4782 col 58| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4785 col 58| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4788 col 58| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4855 col 50| ["IR"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4857 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4858 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4860 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4861 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4863 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4864 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4866 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4867 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4981 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|5042 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5042 col 95| Replace input with ⏎································input,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|5301 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5341 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5381 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5483 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5523 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5564 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5604 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5638 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5719 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5762 col 1| This line has a length of 108. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5773 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5782 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5790 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5794 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5794 col 24| Replace type·===·NeoBlockType.MOTOR_STOP·||·type·===·NeoBlockType.AUTO_DRIVING_STOP with ⏎················type·===·NeoBlockType.MOTOR_STOP·||⏎················type·===·NeoBlockType.AUTO_DRIVING_STOP⏎············
src/playground/blocks/hardwareLite/block_neo_lite.js|5798 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5804 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5809 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5816 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5825 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5834 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5848 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5855 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5862 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5868 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5876 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5882 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5889 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5895 col 1| This line has a length of 103. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5895 col 27| Replace UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.AUTO_DETECT_WALL with ⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.AUTO_DETECT_WALL⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5896 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5904 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5912 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5919 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5924 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5942 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5948 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5954 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5960 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5981 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5981 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.MOTOR with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.MOTOR⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5982 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5987 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5987 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5988 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5991 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5991 col 24| Replace type·===·NeoBlockType.SERVO_ANGLE·||·type·===·NeoBlockType.SERVO_ANGLE_WAIT with ⏎················type·===·NeoBlockType.SERVO_ANGLE·||⏎················type·===·NeoBlockType.SERVO_ANGLE_WAIT⏎············
src/playground/blocks/hardwareLite/block_neo_lite.js|5996 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6004 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6013 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6013 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6014 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6019 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6019 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6020 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6028 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6034 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6038 col 1| This line has a length of 120. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6038 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.BUZZER with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.BUZZER⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6039 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6046 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6081 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6081 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6102 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6102 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6117 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6159 col 13| Closing curly brace does not appear on the same line as the subsequent block.
src/playground/blocks/hardwareLite/block_neo_lite.js|6194 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6194 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6200 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6200 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6221 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6221 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6270 col 13| Closing curly brace does not appear on the same line as the subsequent block.

src/playground/blocks/hardwareLite/block_neo_lite.js
}*/
if (Entry.hwLite) {
const blockId = this.generateBlockId();
const pdu = this.makePdu([FrameCode.BASIC, PduCode.CONTROLLER_COMMAND, blockId, 0x04]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 103. Maximum allowed is 100.

src/playground/blocks/hardwareLite/block_neo_lite.js
}*/
if (Entry.hwLite) {
const blockId = this.generateBlockId();
const pdu = this.makePdu([FrameCode.BASIC, PduCode.CONTROLLER_COMMAND, blockId, 0x04]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace FrameCode.BASIC,·PduCode.CONTROLLER_COMMAND,·blockId,·0x04 with ⏎····················FrameCode.BASIC,⏎····················PduCode.CONTROLLER_COMMAND,⏎····················blockId,⏎····················0x04,⏎················

Suggested change
const pdu = this.makePdu([FrameCode.BASIC, PduCode.CONTROLLER_COMMAND, blockId, 0x04]);
const pdu = this.makePdu([
FrameCode.BASIC,
PduCode.CONTROLLER_COMMAND,
blockId,
0x04,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
const unitId = body[1];
const valueLength = body[2];
const value = body.slice(3, 3 + valueLength);
const buffer = Buffer.from(value);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-undef> reported by reviewdog 🐶
'Buffer' is not defined.

src/playground/blocks/hardwareLite/block_neo_lite.js
}
this.pendingResponseList[blockId] = 'executed';
const command = this.makeCommand(blockId, type, params);
if (!command) return;
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.

Suggested change
if (!command) return;
if (!command) {return;}

src/playground/blocks/hardwareLite/block_neo_lite.js
}
this.pendingResponseList[blockId] = 'executed';
const command = this.makeCommandExt(blockId, type, params);
if (!command) return;
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.

Suggested change
if (!command) return;
if (!command) {return;}

src/playground/blocks/hardwareLite/block_neo_lite.js
const speed = script.getStringField('SPEED', script);
const blockId = this.generateBlockId();
script.block_id = blockId;
this.requestCommand(blockId, NeoBlockType.SERVO_ANGLE, [output, angle, speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 107. Maximum allowed is 100.

src/playground/blocks/hardwareLite/block_neo_lite.js
const speed = script.getStringField('SPEED', script);
const blockId = this.generateBlockId();
script.block_id = blockId;
this.requestCommand(blockId, NeoBlockType.SERVO_ANGLE, [output, angle, speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace output,·angle,·speed with ⏎································output,⏎································angle,⏎································speed,⏎····························

Suggested change
this.requestCommand(blockId, NeoBlockType.SERVO_ANGLE, [output, angle, speed]);
this.requestCommand(blockId, NeoBlockType.SERVO_ANGLE, [
output,
angle,
speed,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
]);
}
} else {
this.requestCommand(blockId, NeoBlockType.SERVO_ANGLE_WAIT, [output, angle, speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 116. Maximum allowed is 100.

src/playground/blocks/hardwareLite/block_neo_lite.js
]);
}
} else {
this.requestCommand(blockId, NeoBlockType.SERVO_ANGLE_WAIT, [output, angle, speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace output,·angle,·speed with ⏎····································output,⏎····································angle,⏎····································speed,⏎································

Suggested change
this.requestCommand(blockId, NeoBlockType.SERVO_ANGLE_WAIT, [output, angle, speed]);
this.requestCommand(blockId, NeoBlockType.SERVO_ANGLE_WAIT, [
output,
angle,
speed,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
const blockId = this.generateBlockId();
script.block_id = blockId;
if (speed.indexOf('IN') >= 0) {
this.requestExtCommand(blockId, NeoBlockType.SERVO_ROTATE, [output, direction, speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 119. Maximum allowed is 100.

github-actions[bot]
github-actions bot reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

src/playground/blocks/hardwareLite/block_neo_lite.js|3689 col 83| Replace output,·speed,·100 with ⏎································output,⏎································speed,⏎································100,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|3700 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|3860 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|3860 col 86| Replace output,·color with ⏎································output,⏎································color,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|3871 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|4001 col 1| This line has a length of 111. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4001 col 96| Replace output,·input with ⏎································output,⏎································input,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|4160 col 1| This line has a length of 106. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4160 col 91| Replace output,·value with ⏎····································output,⏎····································value,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|4162 col 1| This line has a length of 103. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4162 col 88| Replace output,·value with ⏎····································output,⏎····································value,⏎································
src/playground/blocks/hardwareLite/block_neo_lite.js|4174 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|4257 col 51| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4259 col 51| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4261 col 51| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4316 col 51| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4318 col 51| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4320 col 51| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4399 col 52| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4402 col 52| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4405 col 52| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4493 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4494 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4507 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4508 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4509 col 56| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4525 col 62| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4528 col 62| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4531 col 62| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4630 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4631 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4658 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4659 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4660 col 56| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4663 col 1| This line has a length of 105. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4663 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4669 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4669 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4671 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4671 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4675 col 1| This line has a length of 105. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4675 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4681 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4681 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4683 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4683 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4690 col 62| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4693 col 62| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4696 col 62| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4782 col 58| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4785 col 58| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4788 col 58| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4855 col 50| ["IR"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4857 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4858 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4860 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4861 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4863 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4864 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4866 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4867 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4981 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|5042 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5042 col 95| Replace input with ⏎································input,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|5301 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5341 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5381 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5483 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5523 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5564 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5604 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5638 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5719 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5762 col 1| This line has a length of 108. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5773 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5782 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5790 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5794 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5794 col 24| Replace type·===·NeoBlockType.MOTOR_STOP·||·type·===·NeoBlockType.AUTO_DRIVING_STOP with ⏎················type·===·NeoBlockType.MOTOR_STOP·||⏎················type·===·NeoBlockType.AUTO_DRIVING_STOP⏎············
src/playground/blocks/hardwareLite/block_neo_lite.js|5798 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5804 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5809 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5816 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5825 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5834 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5848 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5855 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5862 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5868 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5876 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5882 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5889 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5895 col 1| This line has a length of 103. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5895 col 27| Replace UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.AUTO_DETECT_WALL with ⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.AUTO_DETECT_WALL⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5896 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5904 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5912 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5919 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5924 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5942 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5948 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5954 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5960 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5981 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5981 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.MOTOR with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.MOTOR⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5982 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5987 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5987 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5988 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5991 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5991 col 24| Replace type·===·NeoBlockType.SERVO_ANGLE·||·type·===·NeoBlockType.SERVO_ANGLE_WAIT with ⏎················type·===·NeoBlockType.SERVO_ANGLE·||⏎················type·===·NeoBlockType.SERVO_ANGLE_WAIT⏎············
src/playground/blocks/hardwareLite/block_neo_lite.js|5996 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6004 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6013 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6013 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6014 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6019 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6019 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6020 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6028 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6034 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6038 col 1| This line has a length of 120. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6038 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.BUZZER with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.BUZZER⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6039 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6046 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6081 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6081 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6102 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6102 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6117 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6159 col 13| Closing curly brace does not appear on the same line as the subsequent block.
src/playground/blocks/hardwareLite/block_neo_lite.js|6194 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6194 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6200 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6200 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6221 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6221 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6270 col 13| Closing curly brace does not appear on the same line as the subsequent block.

src/playground/blocks/hardwareLite/block_neo_lite.js
const blockId = this.generateBlockId();
script.block_id = blockId;
if (speed.indexOf('IN') >= 0) {
this.requestExtCommand(blockId, NeoBlockType.SERVO_ROTATE, [output, direction, speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace output,·direction,·speed with ⏎····································output,⏎····································direction,⏎····································speed,⏎································

Suggested change
this.requestExtCommand(blockId, NeoBlockType.SERVO_ROTATE, [output, direction, speed]);
this.requestExtCommand(blockId, NeoBlockType.SERVO_ROTATE, [
output,
direction,
speed,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
if (speed.indexOf('IN') >= 0) {
this.requestExtCommand(blockId, NeoBlockType.SERVO_ROTATE, [output, direction, speed]);
} else {
this.requestCommand(blockId, NeoBlockType.SERVO_ROTATE, [output, direction, speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 116. Maximum allowed is 100.

src/playground/blocks/hardwareLite/block_neo_lite.js
if (speed.indexOf('IN') >= 0) {
this.requestExtCommand(blockId, NeoBlockType.SERVO_ROTATE, [output, direction, speed]);
} else {
this.requestCommand(blockId, NeoBlockType.SERVO_ROTATE, [output, direction, speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace output,·direction,·speed with ⏎····································output,⏎····································direction,⏎····································speed,⏎································

Suggested change
this.requestCommand(blockId, NeoBlockType.SERVO_ROTATE, [output, direction, speed]);
this.requestCommand(blockId, NeoBlockType.SERVO_ROTATE, [
output,
direction,
speed,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
const blockId = this.generateBlockId();
const duration = script.getStringValue('DURATION', script);
if (speed === 'IN1' || speed === 'IN2' || speed === 'IN3') {
this.requestExtCommand(blockId, NeoBlockType.LINE_TRACER_START, [speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 105. Maximum allowed is 100.

src/playground/blocks/hardwareLite/block_neo_lite.js
const blockId = this.generateBlockId();
const duration = script.getStringValue('DURATION', script);
if (speed === 'IN1' || speed === 'IN2' || speed === 'IN3') {
this.requestExtCommand(blockId, NeoBlockType.LINE_TRACER_START, [speed]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace speed with ⏎····································speed,⏎································

Suggested change
this.requestExtCommand(blockId, NeoBlockType.LINE_TRACER_START, [speed]);
this.requestExtCommand(blockId, NeoBlockType.LINE_TRACER_START, [
speed,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
const duration = script.getStringValue('DURATION', script);
const blockId = this.generateBlockId();
if (brightness.indexOf('IN') >= 0) {
this.requestExtCommand(blockId, NeoBlockType.LED_ON, [output, brightness]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace output,·brightness with ⏎····································output,⏎····································brightness,⏎································

Suggested change
this.requestExtCommand(blockId, NeoBlockType.LED_ON, [output, brightness]);
this.requestExtCommand(blockId, NeoBlockType.LED_ON, [
output,
brightness,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
if (brightness.indexOf('IN') >= 0) {
this.requestExtCommand(blockId, NeoBlockType.LED_ON, [output, brightness]);
} else {
this.requestCommand(blockId, NeoBlockType.LED_ON, [output, brightness]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 104. Maximum allowed is 100.

src/playground/blocks/hardwareLite/block_neo_lite.js
if (brightness.indexOf('IN') >= 0) {
this.requestExtCommand(blockId, NeoBlockType.LED_ON, [output, brightness]);
} else {
this.requestCommand(blockId, NeoBlockType.LED_ON, [output, brightness]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace output,·brightness with ⏎····································output,⏎····································brightness,⏎································

Suggested change
this.requestCommand(blockId, NeoBlockType.LED_ON, [output, brightness]);
this.requestCommand(blockId, NeoBlockType.LED_ON, [
output,
brightness,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
const duration = script.getStringValue('DURATION', script);
const durationValue = Entry.parseNumber(duration);
script.exec_phase = ExecPhase.WAIT_TIMEOUT;
setTimeout(function() {
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <prefer-arrow-callback> reported by reviewdog 🐶
Unexpected function expression.

Suggested change
setTimeout(function() {
setTimeout(() => {

src/playground/blocks/hardwareLite/block_neo_lite.js
const speed = script.getStringValue('SPEED', script);
const duration = script.getStringValue('DURATION', script);
const blockId = this.generateBlockId();
this.requestCommand(blockId, NeoBlockType.LED_BLINK, [output, speed, 100]);
Copy link
Contributor

@github-actions github-actions bot Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 103. Maximum allowed is 100.

Tnks2U and others added 3 commits April 24, 2023 18:33
@Tnks2U
fix: 마이크로비트2 웹연결 센서값 오류문제 수정
d7eaf63
@Tnks2U
feat: retryLimit 값 수정
6230cbb 
- 저사양 기기들 고려해서 4정도로 수정
@Tnks2U
Merge pull request #2487 from entrylabs/issue/6150
550ed9d 
[#6150] 마이크로비트2 웹연결 센서값 오류 수정
github-actions[bot]
github-actions bot reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

src/playground/blocks/hardwareLite/block_neo_lite.js|4630 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4631 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4658 col 56| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4659 col 56| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4660 col 56| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4663 col 1| This line has a length of 105. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4663 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4669 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4669 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4671 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4671 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4675 col 1| This line has a length of 105. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4675 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4681 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4681 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4683 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|4683 col 42| Insert ⏎···································
src/playground/blocks/hardwareLite/block_neo_lite.js|4690 col 62| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4693 col 62| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4696 col 62| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4782 col 58| ["in1Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4785 col 58| ["in2Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4788 col 58| ["in3Values"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4855 col 50| ["IR"] is better written in dot notation.
src/playground/blocks/hardwareLite/block_neo_lite.js|4857 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4858 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4860 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4861 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4863 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4864 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4866 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4867 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4981 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|5042 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5042 col 95| Replace input with ⏎································input,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|5301 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5341 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5381 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5483 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5523 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5564 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5604 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5638 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5719 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5762 col 1| This line has a length of 108. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5773 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5782 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5790 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5794 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5794 col 24| Replace type·===·NeoBlockType.MOTOR_STOP·||·type·===·NeoBlockType.AUTO_DRIVING_STOP with ⏎················type·===·NeoBlockType.MOTOR_STOP·||⏎················type·===·NeoBlockType.AUTO_DRIVING_STOP⏎············
src/playground/blocks/hardwareLite/block_neo_lite.js|5798 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5804 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5809 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5816 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5825 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5834 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5848 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5855 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5862 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5868 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5876 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5882 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5889 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5895 col 1| This line has a length of 103. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5895 col 27| Replace UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.AUTO_DETECT_WALL with ⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.AUTO_DETECT_WALL⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5896 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5904 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5912 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5919 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5924 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5942 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5948 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5954 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5960 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5981 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5981 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.MOTOR with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.MOTOR⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5982 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5987 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5987 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5988 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5991 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5991 col 24| Replace type·===·NeoBlockType.SERVO_ANGLE·||·type·===·NeoBlockType.SERVO_ANGLE_WAIT with ⏎················type·===·NeoBlockType.SERVO_ANGLE·||⏎················type·===·NeoBlockType.SERVO_ANGLE_WAIT⏎············
src/playground/blocks/hardwareLite/block_neo_lite.js|5996 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6004 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6013 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6013 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6014 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6019 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6019 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6020 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6028 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6034 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6038 col 1| This line has a length of 120. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6038 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.BUZZER with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.BUZZER⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6039 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6046 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6081 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6081 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6102 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6102 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6117 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6159 col 13| Closing curly brace does not appear on the same line as the subsequent block.
src/playground/blocks/hardwareLite/block_neo_lite.js|6194 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6194 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6200 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6200 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6221 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6221 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6270 col 13| Closing curly brace does not appear on the same line as the subsequent block.

src/playground/blocks/hardwareLite/block_microbit2_lite.js
microbit2lite_get_acc: 'The acceleration value of the selected axis.',
microbit2lite_btn_event: 'When the selected button is pressed, the connected blocks below will run',
microbit2lite_btn_event:
'When the selected button is pressed, the connected blocks below will run',
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 103. Maximum allowed is 100.

src/playground/blocks/hardwareLite/block_neo_lite.js
const speed = script.getStringValue('SPEED', script);
const duration = script.getStringValue('DURATION', script);
const blockId = this.generateBlockId();
this.requestCommand(blockId, NeoBlockType.LED_BLINK, [output, speed, 100]);
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace output,·speed,·100 with ⏎································output,⏎································speed,⏎································100,⏎····························

Suggested change
this.requestCommand(blockId, NeoBlockType.LED_BLINK, [output, speed, 100]);
this.requestCommand(blockId, NeoBlockType.LED_BLINK, [
output,
speed,
100,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
const duration = script.getStringValue('DURATION', script);
const durationValue = Entry.parseNumber(duration);
script.exec_phase = ExecPhase.WAIT_TIMEOUT;
setTimeout(function() {
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <prefer-arrow-callback> reported by reviewdog 🐶
Unexpected function expression.

Suggested change
setTimeout(function() {
setTimeout(() => {

src/playground/blocks/hardwareLite/block_neo_lite.js
const color = script.getStringValue('COLOR', script);
const duration = script.getStringValue('DURATION', script);
const blockId = this.generateBlockId();
this.requestCommand(blockId, NeoBlockType.COLOR_LED_ON, [output, color]);
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.

src/playground/blocks/hardwareLite/block_neo_lite.js
const color = script.getStringValue('COLOR', script);
const duration = script.getStringValue('DURATION', script);
const blockId = this.generateBlockId();
this.requestCommand(blockId, NeoBlockType.COLOR_LED_ON, [output, color]);
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace output,·color with ⏎································output,⏎································color,⏎····························

Suggested change
this.requestCommand(blockId, NeoBlockType.COLOR_LED_ON, [output, color]);
this.requestCommand(blockId, NeoBlockType.COLOR_LED_ON, [
output,
color,
]);

src/playground/blocks/hardwareLite/block_neo_lite.js
}
} else if (input === 'IN123') {
const sensor1 = sensorData['in1Values'][0];
const sensor2 = sensorData['in2Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in2Values"] is better written in dot notation.

Suggested change
const sensor2 = sensorData['in2Values'][0];
const sensor2 = sensorData.in2Values[0];

src/playground/blocks/hardwareLite/block_neo_lite.js
} else if (input === 'IN123') {
const sensor1 = sensorData['in1Values'][0];
const sensor2 = sensorData['in2Values'][0];
const sensor3 = sensorData['in3Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in3Values"] is better written in dot notation.

Suggested change
const sensor3 = sensorData['in3Values'][0];
const sensor3 = sensorData.in3Values[0];

src/playground/blocks/hardwareLite/block_neo_lite.js
let sensorValue = 0;
switch (input) {
case 'IN1':
sensorValue = sensorData['in1Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in1Values"] is better written in dot notation.

Suggested change
sensorValue = sensorData['in1Values'][0];
sensorValue = sensorData.in1Values[0];

src/playground/blocks/hardwareLite/block_neo_lite.js
sensorValue = sensorData['in1Values'][0];
break;
case 'IN2':
sensorValue = sensorData['in2Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in2Values"] is better written in dot notation.

Suggested change
sensorValue = sensorData['in2Values'][0];
sensorValue = sensorData.in2Values[0];

src/playground/blocks/hardwareLite/block_neo_lite.js
sensorValue = sensorData['in2Values'][0];
break;
case 'IN3':
sensorValue = sensorData['in3Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in3Values"] is better written in dot notation.

Suggested change
sensorValue = sensorData['in3Values'][0];
sensorValue = sensorData.in3Values[0];

@Tnks2U
fix: 웹연결 아이콘 수정
1199636 
- 이벤트블록 아이콘도 수정 필요함. 현재 디자인 대기중
github-actions[bot]
github-actions bot reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

src/playground/blocks/hardwareLite/block_neo_lite.js|4866 col 51| Expected { after 'if' condition.
src/playground/blocks/hardwareLite/block_neo_lite.js|4867 col 34| Expected { after 'else'.
src/playground/blocks/hardwareLite/block_neo_lite.js|4981 col 40| Unexpected function expression.
src/playground/blocks/hardwareLite/block_neo_lite.js|5042 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5042 col 95| Replace input with ⏎································input,⏎····························
src/playground/blocks/hardwareLite/block_neo_lite.js|5301 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5341 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5381 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5483 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5523 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5564 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5604 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5638 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5719 col 21| Expected method shorthand.
src/playground/blocks/hardwareLite/block_neo_lite.js|5762 col 1| This line has a length of 108. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5773 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5782 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5790 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5794 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5794 col 24| Replace type·===·NeoBlockType.MOTOR_STOP·||·type·===·NeoBlockType.AUTO_DRIVING_STOP with ⏎················type·===·NeoBlockType.MOTOR_STOP·||⏎················type·===·NeoBlockType.AUTO_DRIVING_STOP⏎············
src/playground/blocks/hardwareLite/block_neo_lite.js|5798 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5804 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5809 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5816 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5825 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5834 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5848 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5855 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5862 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5868 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5876 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5882 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5889 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5895 col 1| This line has a length of 103. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5895 col 27| Replace UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.AUTO_DETECT_WALL with ⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.AUTO_DETECT_WALL⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5896 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5904 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5912 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5919 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5924 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5942 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5948 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5954 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5960 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5981 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5981 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.MOTOR with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.MOTOR⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5982 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5987 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5987 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|5988 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|5991 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|5991 col 24| Replace type·===·NeoBlockType.SERVO_ANGLE·||·type·===·NeoBlockType.SERVO_ANGLE_WAIT with ⏎················type·===·NeoBlockType.SERVO_ANGLE·||⏎················type·===·NeoBlockType.SERVO_ANGLE_WAIT⏎············
src/playground/blocks/hardwareLite/block_neo_lite.js|5996 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6004 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6013 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6013 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6014 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6019 col 1| This line has a length of 119. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6019 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.ROBOT with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.ROBOT⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6020 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6028 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6034 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6038 col 1| This line has a length of 120. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6038 col 27| Replace PduCode.EXTEND_1,·blockId,·UnitId.CONTROLLER,·ActorKind.CONTROLLER,·ControllerCommand.BUZZER with ⏎····················PduCode.EXTEND_1,⏎····················blockId,⏎····················UnitId.CONTROLLER,⏎····················ActorKind.CONTROLLER,⏎····················ControllerCommand.BUZZER⏎················
src/playground/blocks/hardwareLite/block_neo_lite.js|6039 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6046 col 30| 'Buffer' is not defined.
src/playground/blocks/hardwareLite/block_neo_lite.js|6081 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6081 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6102 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6102 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6117 col 1| This line has a length of 102. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6159 col 13| Closing curly brace does not appear on the same line as the subsequent block.
src/playground/blocks/hardwareLite/block_neo_lite.js|6194 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6194 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6200 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6200 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6221 col 1| This line has a length of 101. Maximum allowed is 100.
src/playground/blocks/hardwareLite/block_neo_lite.js|6221 col 37| Insert ⏎···················
src/playground/blocks/hardwareLite/block_neo_lite.js|6270 col 13| Closing curly brace does not appear on the same line as the subsequent block.

src/playground/blocks/hardwareLite/block_neo_lite.js
const rValue = Entry.parseNumber(script.getStringValue('R_VALUE'));

if (input === 'IN12') {
const sensor1 = sensorData['in1Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in1Values"] is better written in dot notation.

Suggested change
const sensor1 = sensorData['in1Values'][0];
const sensor1 = sensorData.in1Values[0];

src/playground/blocks/hardwareLite/block_neo_lite.js

if (input === 'IN12') {
const sensor1 = sensorData['in1Values'][0];
const sensor2 = sensorData['in2Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in2Values"] is better written in dot notation.

Suggested change
const sensor2 = sensorData['in2Values'][0];
const sensor2 = sensorData.in2Values[0];

src/playground/blocks/hardwareLite/block_neo_lite.js
}
return lResult && rResult;
} else if (input === 'IN123') {
const sensor1 = sensorData['in1Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in1Values"] is better written in dot notation.

Suggested change
const sensor1 = sensorData['in1Values'][0];
const sensor1 = sensorData.in1Values[0];

src/playground/blocks/hardwareLite/block_neo_lite.js
return lResult && rResult;
} else if (input === 'IN123') {
const sensor1 = sensorData['in1Values'][0];
const sensor2 = sensorData['in2Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in2Values"] is better written in dot notation.

Suggested change
const sensor2 = sensorData['in2Values'][0];
const sensor2 = sensorData.in2Values[0];

src/playground/blocks/hardwareLite/block_neo_lite.js
} else if (input === 'IN123') {
const sensor1 = sensorData['in1Values'][0];
const sensor2 = sensorData['in2Values'][0];
const sensor3 = sensorData['in3Values'][0];
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <dot-notation> reported by reviewdog 🐶
["in3Values"] is better written in dot notation.

Suggested change
const sensor3 = sensorData['in3Values'][0];
const sensor3 = sensorData.in3Values[0];

src/playground/blocks/hardwareLite/block_neo_lite.js
const value = sensorData['IR'];
if (button === 1) {
if (pressed === 'ON') return value === 10;
else return value !== 10;
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <curly> reported by reviewdog 🐶
Expected { after 'else'.

Suggested change
else return value !== 10;
else {return value !== 10;}

src/playground/blocks/hardwareLite/block_neo_lite.js
if (pressed === 'ON') return value === 10;
else return value !== 10;
} else if (button === 2) {
if (pressed === 'ON') return value === 11;
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.

Suggested change
if (pressed === 'ON') return value === 11;
if (pressed === 'ON') {return value === 11;}

src/playground/blocks/hardwareLite/block_neo_lite.js
else return value !== 10;
} else if (button === 2) {
if (pressed === 'ON') return value === 11;
else return value !== 11;
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <curly> reported by reviewdog 🐶
Expected { after 'else'.

Suggested change
else return value !== 11;
else {return value !== 11;}

src/playground/blocks/hardwareLite/block_neo_lite.js
if (pressed === 'ON') return value === 11;
else return value !== 11;
} else if (button === 3) {
if (pressed === 'ON') return value === 12;
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.

Suggested change
if (pressed === 'ON') return value === 12;
if (pressed === 'ON') {return value === 12;}

src/playground/blocks/hardwareLite/block_neo_lite.js
else return value !== 11;
} else if (button === 3) {
if (pressed === 'ON') return value === 12;
else return value !== 12;
Copy link
Contributor

@github-actions github-actions bot Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <curly> reported by reviewdog 🐶
Expected { after 'else'.

Suggested change
else return value !== 12;
else {return value !== 12;}

@Tnks2U Tnks2U merged commit 0b4000c into develop Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@lizwan lizwan lizwan approved these changes

@kimorkim kimorkim Awaiting requested review from kimorkim

@prisml prisml Awaiting requested review from prisml

@anthonyminyungi anthonyminyungi Awaiting requested review from anthonyminyungi

Assignees

@Tnks2U Tnks2U

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Tnks2U @lizwan @Yejin715 @RoboroboLab @pyocoding @jinirobot1 @entrydev @SketchwareMoon