develop-hw 최신화 #2478
Merged
develop-hw 최신화 #2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Total -- 970.05kb -> 157.61kb (83.75%) /images/block_icon/hardware_bzr2.svg -- 247.28kb -> 0.91kb (99.63%) /images/block_icon/hardware_dc.svg -- 248.25kb -> 1.61kb (99.35%) /images/block_icon/hardware_led.svg -- 249.30kb -> 1.90kb (99.24%) /images/hw/iCOBOT_Front.png -- 174.26kb -> 105.80kb (39.28%) /images/beta_tag.svg -- 0.43kb -> 0.34kb (20.67%) /images/hardware/KKMOO.png -- 50.53kb -> 47.05kb (6.89%) Signed-off-by: ImgBotApp <[email protected]>
Issue/5899 2
Issue/5899
[#5764] 신규 판단, 값블록 구현
[5760] 하드웨어 최소버전안내문구 entrylms => modal로 변경
- 다국어, 블록메뉴 위치 수정
[#5764] 신규 판단, 값블록 구현 추가 수정
[4.23.0] 하드웨어 1.9.40 PR
[ImgBot] Optimize images
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| try { | ||
| await Promise.all(this.execPromises); | ||
| } catch (e) {} | ||
| } catch (e) { } |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
Suggested change
| } catch (e) { } | |
| } catch (e) {} |
| resolve(null); | ||
| } | ||
| ); | ||
| Entry.modal.alert(content, title, { |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎····················
Suggested change
| Entry.modal.alert(content, title, { | |
| Entry.moda | |
| l.alert(content, title, { |
| } | ||
| ); | ||
| Entry.modal.alert(content, title, { | ||
| withDontShowAgain: true |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace withDontShowAgain:·true with ····withDontShowAgain:·true,
Suggested change
| withDontShowAgain: true | |
| withDontShowAgain: true,e |
Comment on lines
+638
to
+639
| withDontShowAgain: true | ||
| }).then((data: { dontShowChecked: boolean }) => { |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ················}) with ····················})⏎····················
Suggested change
| withDontShowAgain: true | |
| }).then((data: { dontShowChecked: boolean }) => { | |
| withDontShowAgain: true }) | |
| ).then((data: { dontShowChecked: boolean }) => { |
| Entry.modal.alert(content, title, { | ||
| withDontShowAgain: true | ||
| }).then((data: { dontShowChecked: boolean }) => { | ||
| const { dontShowChecked } = data || {}; |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
Suggested change
| const { dontShowChecked } = data || {}; | |
| const { dontShowChecked } = data || {}; |
| const { dontShowChecked } = data || {}; | ||
| if (dontShowChecked) { | ||
| localStorage.setItem('skipNoticeHWOldVersion', 'true'); | ||
| } |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
Suggested change
| } | |
| } |
| localStorage.setItem('skipNoticeHWOldVersion', 'true'); | ||
| } | ||
| resolve(null); | ||
| }) |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }) with ····});
Suggested change
| }) | |
| });) |
| localStorage.setItem('skipNoticeHWOldVersion', 'true'); | ||
| } | ||
| resolve(null); | ||
| }) |
Contributor
| contentResult += `${this.Block(block)}\n`; | ||
| try { | ||
| if (index === 0 && Entry.TextCodingUtil.isEventBlock(block)) { | ||
| rootResult = `${this.Block(block)}\n`; |
Contributor
| if (index === 0 && Entry.TextCodingUtil.isEventBlock(block)) { | ||
| rootResult = `${this.Block(block)}\n`; | ||
| } else { | ||
| contentResult += `${this.Block(block)}\n`; |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.