Skip to content

[5760] 하드웨어 최소버전안내문구 entrylms => modal로 변경 #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[5760] 하드웨어 최소버전안내문구 entrylms => modal로 변경 #2462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions src/class/hw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,17 +634,15 @@ export default class Hardware {
if (!dontShowChecked) {
const title = Lang.Msgs.hardware_need_update_title;
const content = Lang.Msgs.hardware_need_update_content;
entrylms
.alert(content, title, { withDontShowAgain: true })
.one(
'click',
(event: any, { dontShowChecked }: { dontShowChecked: boolean }) => {
if (dontShowChecked) {
localStorage.setItem('skipNoticeHWOldVersion', 'true');
}
resolve(null);
}
);
Entry.modal.alert(content, title, {
Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎····················

Suggested change
Entry.modal.alert(content, title, {
Entry.moda
l.alert(content, title, {

withDontShowAgain: true
Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace withDontShowAgain:·true with ····withDontShowAgain:·true,

Suggested change
withDontShowAgain: true
withDontShowAgain: true,e

}).then((data: { dontShowChecked: boolean }) => {
Comment on lines +638 to +639
Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ················}) with ····················})⏎····················

Suggested change
withDontShowAgain: true
}).then((data: { dontShowChecked: boolean }) => {
withDontShowAgain: true })
).then((data: { dontShowChecked: boolean }) => {

const { dontShowChecked } = data || {};
Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
const { dontShowChecked } = data || {};
const { dontShowChecked } = data || {};

if (dontShowChecked) {
Comment on lines +640 to +641
Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ···················· with ························

Suggested change
const { dontShowChecked } = data || {};
if (dontShowChecked) {
const { dontShowChecked } = data || {}; if (dontShowChecked) {

Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
if (dontShowChecked) {
if (dontShowChecked) {

localStorage.setItem('skipNoticeHWOldVersion', 'true');
}
Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
}
}

Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
}
}

resolve(null);
})
Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }) with ····});

Suggested change
})
});)

Copy link
Contributor

@github-actions github-actions bot Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
})
};)

} else {
resolve(null);
}
Expand Down
1 change: 1 addition & 0 deletions types/entry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ declare interface IEntry extends EntryOptions {
hwLite: typeof import('../src/class/hw_lite').default;
hw: import('../src/class/hw').default; // HW instance
interfaceState: { [key: string]: any };
modal: any; // @entrylabs/modal

// 엔트리 전역에 할당된 이벤트 객체
disposeEvent: any;
Expand Down