Skip to content

Conversation

@Tnks2U
Copy link
Collaborator

@Tnks2U Tnks2U commented Mar 15, 2023

https://oss.navercorp.com/entry/entry2/issues/5760

@leunge
#2266 PR은 제거해 주셔도 될 것 같습니다.

@Tnks2U Tnks2U requested review from kimorkim, leunge and prisml March 15, 2023 07:56
@Tnks2U Tnks2U self-assigned this Mar 15, 2023
@github-actions github-actions bot added the issue 내부 이슈 처리를 위한 PR label Mar 15, 2023
@Tnks2U Tnks2U changed the title feat: 하드웨어 최소버전안내문구 entrylms => modal로 변경 [5760] 하드웨어 최소버전안내문구 entrylms => modal로 변경 Mar 15, 2023
resolve(null);
}
);
Entry.modal.alert(content, title, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎····················

Suggested change
Entry.modal.alert(content, title, {
Entry.moda
l.alert(content, title, {

}
);
Entry.modal.alert(content, title, {
withDontShowAgain: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace withDontShowAgain:·true with ····withDontShowAgain:·true,

Suggested change
withDontShowAgain: true
withDontShowAgain: true,e

Comment on lines +638 to +639
withDontShowAgain: true
}).then((data: { dontShowChecked: boolean }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ················}) with ····················})⏎····················

Suggested change
withDontShowAgain: true
}).then((data: { dontShowChecked: boolean }) => {
withDontShowAgain: true })
).then((data: { dontShowChecked: boolean }) => {

Entry.modal.alert(content, title, {
withDontShowAgain: true
}).then((data: { dontShowChecked: boolean }) => {
const { dontShowChecked } = data || {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
const { dontShowChecked } = data || {};
const { dontShowChecked } = data || {};

Comment on lines +640 to +641
const { dontShowChecked } = data || {};
if (dontShowChecked) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ···················· with ························

Suggested change
const { dontShowChecked } = data || {};
if (dontShowChecked) {
const { dontShowChecked } = data || {}; if (dontShowChecked) {

withDontShowAgain: true
}).then((data: { dontShowChecked: boolean }) => {
const { dontShowChecked } = data || {};
if (dontShowChecked) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
if (dontShowChecked) {
if (dontShowChecked) {

const { dontShowChecked } = data || {};
if (dontShowChecked) {
localStorage.setItem('skipNoticeHWOldVersion', 'true');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
}
}

const { dontShowChecked } = data || {};
if (dontShowChecked) {
localStorage.setItem('skipNoticeHWOldVersion', 'true');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
}
}

localStorage.setItem('skipNoticeHWOldVersion', 'true');
}
resolve(null);
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }) with ····});

Suggested change
})
});)

localStorage.setItem('skipNoticeHWOldVersion', 'true');
}
resolve(null);
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
})
};)

@Tnks2U Tnks2U mentioned this pull request Mar 15, 2023
@Tnks2U Tnks2U merged commit e63c197 into develop Mar 24, 2023
@leunge leunge deleted the issue/5760 branch March 24, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue 내부 이슈 처리를 위한 PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants