-
Notifications
You must be signed in to change notification settings - Fork 496
[5760] 하드웨어 최소버전안내문구 entrylms => modal로 변경 #2462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| resolve(null); | ||
| } | ||
| ); | ||
| Entry.modal.alert(content, title, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎····················
| Entry.modal.alert(content, title, { | |
| Entry.moda | |
| l.alert(content, title, { |
| } | ||
| ); | ||
| Entry.modal.alert(content, title, { | ||
| withDontShowAgain: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace withDontShowAgain:·true with ····withDontShowAgain:·true,
| withDontShowAgain: true | |
| withDontShowAgain: true,e |
| withDontShowAgain: true | ||
| }).then((data: { dontShowChecked: boolean }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ················}) with ····················})⏎····················
| withDontShowAgain: true | |
| }).then((data: { dontShowChecked: boolean }) => { | |
| withDontShowAgain: true }) | |
| ).then((data: { dontShowChecked: boolean }) => { |
| Entry.modal.alert(content, title, { | ||
| withDontShowAgain: true | ||
| }).then((data: { dontShowChecked: boolean }) => { | ||
| const { dontShowChecked } = data || {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
| const { dontShowChecked } = data || {}; | |
| const { dontShowChecked } = data || {}; |
| const { dontShowChecked } = data || {}; | ||
| if (dontShowChecked) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ···················· with ························
| const { dontShowChecked } = data || {}; | |
| if (dontShowChecked) { | |
| const { dontShowChecked } = data || {}; if (dontShowChecked) { |
| withDontShowAgain: true | ||
| }).then((data: { dontShowChecked: boolean }) => { | ||
| const { dontShowChecked } = data || {}; | ||
| if (dontShowChecked) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
| if (dontShowChecked) { | |
| if (dontShowChecked) { |
| const { dontShowChecked } = data || {}; | ||
| if (dontShowChecked) { | ||
| localStorage.setItem('skipNoticeHWOldVersion', 'true'); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
| } | |
| } |
| const { dontShowChecked } = data || {}; | ||
| if (dontShowChecked) { | ||
| localStorage.setItem('skipNoticeHWOldVersion', 'true'); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
| } | |
| } |
| localStorage.setItem('skipNoticeHWOldVersion', 'true'); | ||
| } | ||
| resolve(null); | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }) with ····});
| }) | |
| });) |
| localStorage.setItem('skipNoticeHWOldVersion', 'true'); | ||
| } | ||
| resolve(null); | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://oss.navercorp.com/entry/entry2/issues/5760
@leunge
#2266 PR은 제거해 주셔도 될 것 같습니다.