Use common include directory for all ports #9983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
common_include_dir
branch
from
114ba7d to
2afe56a
Compare
kripken
approved these changes
Dec 9, 2019
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm, although I am slightly worried we may not have enough test coverage to catch corner cases in all the ports...
embuilder.py
Outdated
| help='force rebuild of target (by removing it first)') | ||
| parser.add_argument('operation') | ||
| parser.add_argument('targets', nargs='+') | ||
| parser.add_argument('operation', help='currnetly only "build" is supported') |
| includes = [i.strip() for i in includes.splitlines()[1:-1]] | ||
| for i in includes: | ||
| self.assertContained(path_from_root('system'), i) | ||
| if shared.Cache.dirname in i: |
Member
There was a problem hiding this comment.
this isn't clear to me. perhaps a comment?
Collaborator
Author
There was a problem hiding this comment.
Sorry this isn't best test in the world. Adding a comment.
We already use a common "lib" directory to install al the libs. This change simply installs headers in the same common "sysroot". This makes the ports install more like normall "make install" scripts would. The only port I didn't include here was cocos2d because it seemed a little overwhelming.
Collaborator
Author
|
Added a ChangeLog entry since this change could be user visible in some cases. |
sbc100
force-pushed
the
common_include_dir
branch
from
94067bc to
b8d95e3
Compare
sbc100
added a commit
that referenced
this pull request
Dec 12, 2019
sbc100
added a commit
that referenced
this pull request
Dec 12, 2019
Also add basic sdl2_mixer test outside of browser tests that just tests for successful compilation. Fixes #10015
sbc100
added a commit
that referenced
this pull request
Dec 13, 2019
Also add basic sdl2_mixer test outside of browser tests that just tests for successful compilation. Fixes #10015
sbc100
added a commit
that referenced
this pull request
Dec 16, 2019
Beuc
added a commit
to Beuc/emscripten
that referenced
this pull request
Mar 12, 2020
This isn't necessary anymore since emscripten-core#9983 / 5d222c1 (common include/ directory).
This was referenced Mar 12, 2020
kripken
pushed a commit
that referenced
this pull request
Mar 17, 2020
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
We already use a common "lib" directory to install all the libs. This change simply installs headers in the same common "sysroot". This makes the ports install more like normal "make install" scripts would.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…ten-core#10021) Also add basic sdl2_mixer test outside of browser tests that just tests for successful compilation. Fixes emscripten-core#10015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use a common "lib" directory to install al the libs. This
change simply installs headers in the same common "sysroot".
This makes the ports install more like normall "make install" scripts
would.
The only port I didn't include here was cocos2d because it seemed a
little overwhelming.