Fix SDL_mixer header installation after #9983 #10021
Conversation
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
I think I mentioned in another PR or issue, I think a better direction would be to compile but not run the audio tests. That is, we currently say our CI lacks audio, so we skip those tests, but instead we could still build them, just not run them.
There is precedent for that, if too many browser tests are unresponsive then we keep building, but stop running (as we assume the browser is "stuck"). That happens at the top of run_browser. Perhaps we could add a similar mechanism for audio and other things?
tools/system_libs.py
Outdated
| for f in glob.glob(os.path.join(src_dir, pattern)): | ||
| logger.debug(os.path.join(dest, os.path.basename(f))) | ||
| matches = glob.glob(os.path.join(src_dir, pattern)) | ||
| assert matches |
There was a problem hiding this comment.
perhaps add an error message? otherwise the error will be unclear.
There was a problem hiding this comment.
This is an assertion, for developers only. No user should ever see this, its for debugging while building/modifying ports.
There was a problem hiding this comment.
But i'll add a message anyway :)
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Personally I prefer a test that doesn't live in test_browser at all. Then I can run it locally without launching a browser at all.
I'm happy to have the audio tests build-only during browser tests, but I think we should have at least one test in test_other for each of out ports. I consider those two things orthogonal.
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Fair enough, agreed on both counts.
Also add basic sdl2_mixer test outside of browser tests that just tests for successful compilation. Fixes #10015
sbc100
force-pushed
the
fix_sdl_mixer
branch
from
d749c2b to
5c0b6ae
Compare
…ten-core#10021) Also add basic sdl2_mixer test outside of browser tests that just tests for successful compilation. Fixes emscripten-core#10015
Also add basic sdl2_mixer test outside of browser tests that just
tests for successful compilation.
Fixes #10015