Don't EXPORT_ALL for linkable code #7371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t internally [ci skip]
…ter-casts' into temp
Beuc
pushed a commit
to Beuc/emscripten
that referenced
this pull request
Nov 17, 2018
This is a breaking change, in which we no longer set EXPORT_ALL in MAIN_MODULEs and SIDE_MODULEs. This makes our linking behavior more "standard", and is more future-proof for wasm backend linking. Fixes emscripten-core#5586, fixes emscripten-core#7189. See more context there.
Closed
sbc100
added a commit
that referenced
this pull request
Dec 20, 2019
This matches the current behavior of fastcomp since #7371 disabled EXPORT_ALL for MAIN/SIDE_MODULEs. Since most of our dylink tests set EXPORT_ALL this didn't get noticed.
sbc100
added a commit
that referenced
this pull request
Dec 20, 2019
This matches the current behavior of fastcomp since #7371 disabled EXPORT_ALL for MAIN/SIDE_MODULEs. Since most of our dylink tests set EXPORT_ALL this didn't get noticed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, in which we no longer set EXPORT_ALL in MAIN_MODULEs and SIDE_MODULEs.
Fixes #5586, fixes #7189. See more context there.