wasm-backend: Don't export symbols by default from MAIN/SIDE_MODULEs #10081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the current behavior of fastcomp since #7371 disabled EXPORT_ALL for MAIN/SIDE_MODULEs. Since most of our dylink tests set EXPORT_ALL this didn't get noticed.
sbc100
force-pushed
the
match_export_all_behaviour_with_fastcomp
branch
from
2ac6d02 to
1bf0514
Compare
kripken
reviewed
Dec 20, 2019
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
I think this is maybe not the way to go. My understanding of EXPORT_ALL is that it exports stuff onto the Module object, and nothing more. It has no effect on keeping code alive through compiling and linking, in particular.
(It is true that it also affects metadce, which is arguably odd, but that's a special optimization after normal compilation and linking, so it's debatable; perhaps we should remove that.)
So I don't think EXPORT_ALL should be used when interfacing with LLVM, clang, wasm-ld, etc. It should just affect exporting JS stuff onto Module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the current behavior of fastcomp since #7371 disabled
EXPORT_ALL for MAIN/SIDE_MODULEs.
Since most of our dylink tests set EXPORT_ALL this didn't get noticed.