Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 28, 2025

I want to get baseline before landing #24190

@sbc100 sbc100 requested review from RReverser and kripken April 28, 2025 14:47
I want to get baseline before landing emscripten-core#24190
@sbc100 sbc100 force-pushed the audio_worklet_codesize_test branch from 2ce6dac to ce9075e Compare April 28, 2025 14:51
@sbc100 sbc100 changed the title Add a codesize test for AUDIO_WORKLET Add a codesize test for AUDIO_WORKLET. NFC Apr 28, 2025
@RReverser
Copy link
Collaborator

Hm but you're merging those files anyway, are you going to compare by manually summing up the sizes before PR vs size of the merged one after?

@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 28, 2025

Hm but you're merging those files anyway, are you going to compare by manually summing up the sizes before PR vs size of the merged one after?

These code size test report total and total_gz sizes as well as individual file sizes, so as long as the total goes down we know we are improving things and not regressing.

@sbc100 sbc100 merged commit c2924cd into emscripten-core:main Apr 28, 2025
25 of 28 checks passed
@sbc100 sbc100 deleted the audio_worklet_codesize_test branch April 28, 2025 17:03
"a.aw.js.gz": 922,
"a.wasm": 1287,
"a.wasm.gz": 859,
"total": 7208,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See these totals here @RReverser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants