[AUDIO_WORKLET] Inline `.aw.js` file into the main output `.js` file #24190

sbc100 · 2025-04-25T16:36:33Z

This is similar to what we already did for pthreads (#24163) and normal wasm workers (#24163). By integrating this file we can actually share more startup code with normal wasm workers.

cwoffenden · 2025-04-25T16:51:33Z

This is awesome, thanks for taking the time to do this. I'll try to look at it next week.

src/audio_worklet.js

test/webaudio/audioworklet.c

src/audio_worklet.js

src/parseTools.mjs

src/wasm_worker.js

tools/link.py

src/audio_worklet.js

I want to get baseline before landing emscripten-core#24190

I want to get baseline before landing #24190

test/code_size/audio_worklet_wasm.json

I'm having some trouble getting this test to pass in emscripten-core#24190 and even having trouble getting to pass on my desktop.

I'm having some trouble getting this test to pass in #24190 and even having trouble getting to pass on my desktop.

At least under chrome it seems that the main thread doesn't run at all until the first few frames have been produced. This fixes the test failures I've been seeing while working on #24190

This is similar to what we already did for pthreads (emscripten-core#24163) and normal wasm workers (emscripten-core#24163). By integrating this file we can actually share more startup code with normal wasm workers.

sbc100 · 2025-04-29T19:06:33Z

Ok, I think this is ready to land now. Hopefully the tests will pass..

This is now possible thanks for emscripten-core#24190.

This is now possible thanks for #24190.

…WorkerGlobalScope.name parameter. (#24933) Way back I recall I did not want to target Worker's `name` parameter given it had browser version requirements, and listed to be a [debugging feature](https://html.spec.whatwg.org/multipage/workers.html#dom-worker-dev). Though now that we have crossed that line, update minimum browser version feature matrix to require `name` support (e.g. after #24190), up[date the minimum required browser versions to highlight this fact. We could maintain separate min required versions for singlethreaded and multithreaded builds, although given that the minimum browser version bump here is relatively small, probably no bother. Although the version bump does mean that Emscripten does no longer support iPhone 5 devices. Fortunately they are very old by now, so practically absent.

sbc100 requested a review from juj April 25, 2025 16:36

sbc100 force-pushed the audio_worklets_single_file branch 5 times, most recently from 40e91c1 to 8b50f40 Compare April 25, 2025 16:45

sbc100 requested review from RReverser and kripken April 25, 2025 16:46

sbc100 force-pushed the audio_worklets_single_file branch from 8b50f40 to 4a7af60 Compare April 25, 2025 16:47

sbc100 force-pushed the audio_worklets_single_file branch from 4a7af60 to dac37b0 Compare April 25, 2025 17:11

cwoffenden reviewed Apr 25, 2025

View reviewed changes

src/audio_worklet.js Show resolved Hide resolved

sbc100 force-pushed the audio_worklets_single_file branch 3 times, most recently from a338a78 to 4b96785 Compare April 25, 2025 19:09

cwoffenden reviewed Apr 25, 2025

View reviewed changes

src/audio_worklet.js Show resolved Hide resolved

cwoffenden reviewed Apr 25, 2025

View reviewed changes

test/webaudio/audioworklet.c Outdated Show resolved Hide resolved

sbc100 force-pushed the audio_worklets_single_file branch 4 times, most recently from e5af49e to d1ed5fb Compare April 28, 2025 04:18