Fix socket ID used in socket events when multiple sockets are used. NFC #22505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Sep 4, 2024
sbc100
force-pushed
the
fix_websocket
branch
from
6bb7e95 to
d3f8990
Compare
sbc100
force-pushed
the
fix_websocket
branch
from
7ddc85d to
c9da57a
Compare
We currently lack tests that use multiple sockets at the same time. Fixes: emscripten-core#22376
kripken
approved these changes
Sep 5, 2024
sbc100
force-pushed
the
fix_websocket
branch
from
c9da57a to
b9a8a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were lacking tests that used multiple sockets at the same time.
Fixes: #22376