Skip to content

Commit b9a8a7c

Browse files
committed
feedback
1 parent e42cc12 commit b9a8a7c

File tree

1 file changed

+21
-19
lines changed

1 file changed

+21
-19
lines changed

test/websocket/test_websocket_send.c

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -37,26 +37,27 @@ EM_BOOL WebSocketMessage(int eventType, const EmscriptenWebSocketMessageEvent *e
3737
printf("text data: \"%s\"\n", e->data);
3838
assert(strcmp((const char*)e->data, "hello on the other side") == 0);
3939
text_received++;
40+
return 0;
41+
}
42+
43+
// We expect to receive the text message before the binary one
44+
assert(text_received);
45+
printf("binary data:");
46+
for (int i = 0; i < e->numBytes; ++i) {
47+
printf(" %02X", e->data[i]);
48+
assert(e->data[i] == i);
49+
}
50+
printf("\n");
51+
emscripten_websocket_close(e->socket, 0, 0);
52+
emscripten_websocket_delete(e->socket);
53+
if (e->socket == sock1) {
54+
sock1 = 0;
4055
} else {
41-
// We expect to receive the text message beofre the binary one
42-
assert(text_received);
43-
printf("binary data:");
44-
for (int i = 0; i < e->numBytes; ++i) {
45-
printf(" %02X", e->data[i]);
46-
assert(e->data[i] == i);
47-
}
48-
printf("\n");
49-
emscripten_websocket_close(e->socket, 0, 0);
50-
emscripten_websocket_delete(e->socket);
51-
if (e->socket == sock1) {
52-
sock1 = 0;
53-
} else {
54-
sock2 = 0;
55-
}
56-
// Once both sockets are closed we are done.
57-
if (!sock1 && !sock2) {
58-
emscripten_force_exit(0);
59-
}
56+
sock2 = 0;
57+
}
58+
// Once both sockets are closed we are done.
59+
if (!sock1 && !sock2) {
60+
emscripten_force_exit(0);
6061
}
6162

6263
return 0;
@@ -125,4 +126,5 @@ int main() {
125126
sock1 = create_socket();
126127
sock2 = create_socket();
127128
emscripten_exit_with_live_runtime();
129+
return 0;
128130
}

0 commit comments

Comments
 (0)