Disable bulk memory on wasm64 for older Node.js #20562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bulk memory for wasm64 was implemented in V8 at v8/v8@18469ec which was first shipped in Node.js 18 (thanks @kleisauke). Split out from emscripten-core#20549 where this was caught initially. Fixes emscripten-core#20560.
kripken
reviewed
Oct 30, 2023
kripken
approved these changes
Oct 31, 2023
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 1, 2023
Using `logger.warning` here instead of `diagnostics.warning` means that this warning cannot be suppressed and I'm now seeing this for all wasm64 tests. Probably better to simply not show a warning here since we don't show warnings when `feature_matrix.caniuse` disables other features.
sbc100
added a commit
that referenced
this pull request
Nov 1, 2023
Using `logger.warning` here instead of `diagnostics.warning` means that this warning cannot be suppressed and I'm now seeing this for all wasm64 tests. Probably better to simply not show a warning here since we don't show warnings when `feature_matrix.caniuse` disables other features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk memory for wasm64 was implemented in V8 at v8/v8@18469ec which was first shipped in Node.js 18 (thanks @kleisauke).
Split out from #20549 where this was caught initially.
Fixes #20560.