Skip to content

Commit 16c0c5d

Browse files
committed
Remove logger.warning introduced in emscripten-core#20562
Using `logger.warning` here instead of `diagnostics.warning` means that this warning cannot be suppressed and I'm now seeing this for all wasm64 tests. Probably better to simply not show a warning here since we don't show warnings when `feature_matrix.caniuse` disables other features.
1 parent c188a2c commit 16c0c5d

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

emcc.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2535,7 +2535,7 @@ def phase_linker_setup(options, state, newargs):
25352535
settings.SUPPORTS_PROMISE_ANY = feature_matrix.caniuse(feature_matrix.Feature.PROMISE_ANY)
25362536
if not settings.BULK_MEMORY:
25372537
settings.BULK_MEMORY = feature_matrix.caniuse(feature_matrix.Feature.BULK_MEMORY)
2538-
if settings.MEMORY64 and settings.MIN_NODE_VERSION < 180000:
2538+
if settings.BULK_MEMORY and settings.MEMORY64 and settings.MIN_NODE_VERSION < 180000:
25392539
# Note that we do not update tools/feature_matrix.py for this, as this issue is
25402540
# wasm64-specific: bulk memory for wasm32 has shipped in Node.js 12.5, but
25412541
# bulk memory for wasm64 has shipped only in Node.js 18.
@@ -2545,10 +2545,6 @@ def phase_linker_setup(options, state, newargs):
25452545
# denominator and disable bulk memory altogether for Node.js < 18 or to
25462546
# special-case this situation here. The former would be limiting for
25472547
# wasm32 users, so instead we do the latter:
2548-
logger.warning(
2549-
"Disabling bulk memory because it doesn't work correctly with wasm64 in Node.js < 18.\n"
2550-
"Set MIN_NODE_VERSION to 180000 or above to enable it."
2551-
)
25522548
settings.BULK_MEMORY = 0
25532549

25542550
if settings.AUDIO_WORKLET:

0 commit comments

Comments
 (0)