Add auto-generated sigs for the fetch API. NFC #19067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
approved these changes
Mar 24, 2023
sbc100
force-pushed
the
gen_sig_info_fetch
branch
from
8bef1d1 to
69a3bc6
Compare
sbc100
force-pushed
the
gen_sig_info_fetch
branch
2 times, most recently
from
20107c1 to
c94fab9
Compare
Followup to #19028 which laid the groundwork for auto-generated sigs.
sbc100
force-pushed
the
gen_sig_info_fetch
branch
from
c94fab9 to
32a40cc
Compare
RReverser
pushed a commit
that referenced
this pull request
Mar 29, 2023
Followup to #19028 which laid the groundwork for auto-generated sigs.
sbc100
added a commit
that referenced
this pull request
Mar 31, 2023
This test was updated in #19046, but went through CI before #19067 landed which made duplicate signatures into a warning. `glDrawRangeElements` is defined both in `library_glemu.js` and in `library_webgl2.js` with the former taking precedence because it is included later. This change avoid the duplicate definition.
sbc100
added a commit
that referenced
this pull request
Mar 31, 2023
This test was updated in #19046, but went through CI before #19067 landed which made duplicate signatures into a warning. `glDrawRangeElements` is defined both in `library_glemu.js` and in `library_webgl2.js` with the former taking precedence because it is included later. This change avoid the duplicate definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #19028 which laid the groundwork for auto-generated sigs.