Start using auto-generated sigs from library_sigs.js. NFC #19028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
gen_sig_info
branch
2 times, most recently
from
ab12d00 to
61a91ba
Compare
sbc100
force-pushed
the
gen_sig_info_use
branch
from
2db7f63 to
7809371
Compare
sbc100
force-pushed
the
gen_sig_info_use
branch
3 times, most recently
from
c332186 to
ed9785a
Compare
sbc100
force-pushed
the
gen_sig_info_use
branch
from
ed9785a to
abe77f7
Compare
kripken
approved these changes
Mar 22, 2023
sbc100
force-pushed
the
gen_sig_info_use
branch
3 times, most recently
from
0d784a2 to
1661145
Compare
sbc100
added a commit
that referenced
this pull request
Mar 23, 2023
sbc100
added a commit
that referenced
this pull request
Mar 23, 2023
sbc100
added a commit
that referenced
this pull request
Mar 23, 2023
sbc100
force-pushed
the
gen_sig_info_use
branch
from
1661145 to
3b04363
Compare
sbc100
added a commit
that referenced
this pull request
Mar 24, 2023
sbc100
added a commit
that referenced
this pull request
Mar 24, 2023
sbc100
force-pushed
the
gen_sig_info_use
branch
from
3b04363 to
1ab7f70
Compare
The sigs here were removed by running `tools/gen_sig_info.py --remove` Currently the auto-generated signature cover 906 of the 1279 total signatures we have in the JS library. Hopefully we can figure out a way to remove the rest too, but that work can happen in followups.
sbc100
force-pushed
the
gen_sig_info_use
branch
from
1ab7f70 to
4527b1f
Compare
sbc100
added a commit
that referenced
this pull request
Mar 24, 2023
Followup to #19028 which laid the groundwork for auto-generated sigs.
sbc100
added a commit
that referenced
this pull request
Mar 24, 2023
Followup to #19028 which laid the groundwork for auto-generated sigs.
sbc100
added a commit
that referenced
this pull request
Mar 24, 2023
Followup to #19028 which laid the groundwork for auto-generated sigs.
sbc100
added a commit
that referenced
this pull request
Mar 25, 2023
Followup to #19028 which laid the groundwork for auto-generated sigs.
sbc100
added a commit
that referenced
this pull request
Mar 27, 2023
Followup to #19028 which laid the groundwork for auto-generated sigs.
sbc100
added a commit
that referenced
this pull request
Mar 27, 2023
Followup to #19028 which laid the groundwork for auto-generated sigs.
RReverser
pushed a commit
that referenced
this pull request
Mar 29, 2023
Followup to #19028 which laid the groundwork for auto-generated sigs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sigs here were removed by running
tools/gen_sig_info.py --removeCurrently the auto-generated signature cover 906 of the 1279 total signatures we have in the JS library. Hopefully we can figure out a way to remove the rest too, but that work can happen in followups.