Initial usage of ES6 features #15764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2021
sbc100
changed the title
sbc100
force-pushed
the
closure_transpile_only
branch
3 times, most recently
from
99827f4 to
0346d1c
Compare
kripken
reviewed
Dec 13, 2021
There was a problem hiding this comment.
Interesting!
The main question for me here is closure. Closure advanced opts are fairly slow, as we know (though very much worth it!) - how fast is closure transpilation? We would be forcing people to use closure if they support older browsers, so an idea of the cost would be good.
Hopefully it's fast enough. Faster than other transpilation tools (Babel) would be good enough I think.
emcc.py
Outdated
| settings.TRANSPILE = (settings.MIN_FIREFOX_VERSION < 44 or | ||
| settings.MIN_CHROME_VERSION < 49 or | ||
| settings.MIN_SAFARI_VERSION < 11000 or | ||
| settings.MIN_IE_VERSION != 0x7FFFFFFF) |
sbc100
force-pushed
the
closure_transpile_only
branch
4 times, most recently
from
3213444 to
af6ba01
Compare
With this change we allow these features by default. If a user explicitly opts into older browser support we trigger the running of closure compiler with `--language_out ES5 --compilation_level WHITESPACE_ONLY`. For most users this will be a code size win, but otherwise a no-op. For users who need older browser support they will now have their output run though closure by default. If they want to take a care of the transpilaion process themselves rather than have emscripten to it auto-magically they can run with `--closure=0`. When we auto-magically run closure to do transpilation we generate a warning. This warning can be suppressed by add `--closure=1` to explicitly opt in, or `--closure=0` to explicitly opt out. This change in does not actually include any usage of these features and so don't include the code size benefits. Those will be part of followup PRs. Fixes: #11984
sbc100
force-pushed
the
closure_transpile_only
branch
from
af6ba01 to
1a9d0b5
Compare
sbc100
force-pushed
the
closure_transpile_only
branch
6 times, most recently
from
fe16954 to
bc31c66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a followup to #15763 which actually starts to use
some ES6 features in our core library code.
This change is designed to demonstrate that code size
wins that we can get from ES6 usage.
See: #11984