Initial usage of ES6 in JS library code #15765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2021
sbc100
force-pushed
the
initial_es6
branch
2 times, most recently
from
3c9d594 to
bd2e5c6
Compare
sbc100
force-pushed
the
use_es6
branch
3 times, most recently
from
a791242 to
f16903e
Compare
sbc100
changed the title
=>) in JS library code
sbc100
changed the title
tlively
approved these changes
Dec 20, 2021
| f = re.sub(r'\s*function\s*\(Module\)\s*{\s*Module\s*=\s*Module\s*\|\|\s*{\s*}\s*;\s*var\s+(\w+)\s*=\s*Module\s*;', r'function(\1){', f) | ||
|
|
||
| # Same as above but for arrow function | ||
| f = re.sub(r'\s*\(Module\)\s*=>\s*{\s*Module\s*=\s*Module\s*\|\|\s*{\s*}\s*;\s*var\s+(\w+)\s*=\s*Module\s*;', r'(\1)=>{', f) |
Member
There was a problem hiding this comment.
Is there a test that exercises this?
Collaborator
Author
There was a problem hiding this comment.
Yes, without this there is a test that fails... i don't remember which one I'm afraid.
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
Now that ES6 features are permitted in emscripten JS library code (see emscripten-core#15763) we can take advantage of some of them to reduce size of our output JS. This is just an initial test of using ES6 features. See: emscripten-core#11984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that ES6 features are permitted in emscripten JS library
code (see #15763) we can take advantage of some of them to
reduce size of our output JS.
This is just an initial test of using ES6 features.
See: #11984