Fix _memset is not defined errors in asan builds
#15654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_withBuiltinMalloc
branch
from
c9f75a7 to
8f8912f
Compare
kripken
approved these changes
Nov 30, 2021
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
…5654) I recently landed emscripten-core#15617 which inadvertently broke asan builds because, under asan, there was a real dependency on `_memset` in the `withBuiltinMalloc` wrapper. However this dependency is no longer needed since the use of `_memset` was removed from the JS library code in emscripten-core#14441.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently landed #15617 which inadvertently broke asan builds because,
under asan, there was a real dependency on
_memsetin thewithBuiltinMallocwrapper. However this dependency is no longerneeded since the use of
_memsetwas removed from the JS library codein #14441.