Remove unnecessary export of memset. NFC #15617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is kind of in the wrong place. If we wanted to keep
it we could move it to emcc.py:2164 where we export symbols needed
by the sanitizers:
```
if sanitize:
settings.USE_OFFSET_CONVERTER = 1
settings.EXPORTED_FUNCTIONS += [
'_memalign',
'_emscripten_builtin_memalign',
'_emscripten_builtin_malloc',
'_emscripten_builtin_free',
'___heap_base',
'___global_base'
]
```
However, I don't think we do need. The comment set that `memset` is
needed for `mmap` but `mmap` uses the `zeroMemory` JS function which
does not depend on `memset` (perhaps it once did?)
kripken
approved these changes
Nov 24, 2021
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Yes, I guess once we needed memset but no longer do. lgtm if tests pass.
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
This code is kind of in the wrong place. If we wanted to keep
it we could move it to emcc.py:2164 where we export symbols needed
by the sanitizers:
```
if sanitize:
settings.USE_OFFSET_CONVERTER = 1
settings.EXPORTED_FUNCTIONS += [
'_memalign',
'_emscripten_builtin_memalign',
'_emscripten_builtin_malloc',
'_emscripten_builtin_free',
'___heap_base',
'___global_base'
]
```
However, I don't think we do need it. The comment set that `memset` is
needed for `mmap` but `mmap` uses the `zeroMemory` JS function which
does not depend on `memset` (perhaps it once did?)
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
…5654) I recently landed emscripten-core#15617 which inadvertently broke asan builds because, under asan, there was a real dependency on `_memset` in the `withBuiltinMalloc` wrapper. However this dependency is no longer needed since the use of `_memset` was removed from the JS library code in emscripten-core#14441.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is kind of in the wrong place. If we wanted to keep
it we could move it to emcc.py:2164 where we export symbols needed
by the sanitizers:
However, I don't think we do need it. The comment set that
memsetisneeded for
mmapbutmmapuses thezeroMemoryJS function whichdoes not depend on
memset(perhaps it once did?)