More use of pathlib in test code. NFC #14191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
more_pathlib_in_tests
branch
4 times, most recently
from
5a4dbb9 to
3d9ce4b
Compare
aheejin
approved these changes
May 14, 2021
sbc100
force-pushed
the
more_pathlib_in_tests
branch
2 times, most recently
from
4bf471b to
c22b951
Compare
Followup to #14175. Again I think this makes many tests more readable.
sbc100
force-pushed
the
more_pathlib_in_tests
branch
from
c22b951 to
5ef158f
Compare
sbc100
added a commit
that referenced
this pull request
Aug 19, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 19, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 19, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 19, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 20, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 20, 2021
…FC (#14916) This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #14175. Again I think this makes many tests more readable.