Use python3's pathlib in test code. NFC #14175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
use_pathlib_in_tests
branch
4 times, most recently
from
6aa5010 to
69b3b96
Compare
kripken
reviewed
May 13, 2021
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
In general this looks good. We don't have a lot of windows testing here though, have you done any additional tests, or do you think this is enough?
Collaborator
Author
Maybe I can do a CI run with windows running all of wasm2 and other? That should do it. |
Member
|
Sounds good. I guess the autoroller will also catch this eventually too. |
sbc100
force-pushed
the
use_pathlib_in_tests
branch
4 times, most recently
from
fd80061 to
b914616
Compare
Collaborator
Author
|
All windows tests in other and wasm2 pass.. except for |
rth
reviewed
May 14, 2021
Contributor
rth
left a comment
rth
left a comment
There was a problem hiding this comment.
This allows us to use unix-like paths throughout the tests that will
get converted to windows-paths on windows machines automatically
by the pathlib library.
Interesting, I wasn't aware this was possible. Thanks for working on this!
There are plans underway to start using pathlib more in emscripten. See: #14074 This change a designed to test the water by using `pathlib` in test code. This allows us to use unix-like paths throughout the tests that will get converted to windows-paths on windows machines automatically by the pathlib library.
sbc100
force-pushed
the
use_pathlib_in_tests
branch
from
b914616 to
0462788
Compare
kripken
approved these changes
May 14, 2021
sbc100
added a commit
that referenced
this pull request
May 14, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
May 14, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
May 14, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
May 14, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
May 14, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
May 14, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
May 14, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
May 15, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
May 15, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
May 15, 2021
Followup to #14175. Again I think this makes many tests more readable.
sbc100
added a commit
that referenced
this pull request
Aug 19, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 19, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 19, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 19, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 20, 2021
This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
sbc100
added a commit
that referenced
this pull request
Aug 20, 2021
…FC (#14916) This change is very much like that large change I made to the test suite. See #14191 and #14175. It enables is to use unix style paths rather than arrays of path components which has several advantages. As well as beeing more readable and writable it also allows for things like `git grep "musl/src"` to work as expected. For an example of how much more readable it makes the code see `tools/system_libs.py`. This change was made almost exclusively with a bunch of `sed` commands. Because there is likely some minor performance overhead I did some measurements. Running `./tests/runner wasm2 --skip-slow`: before: real 1m10.403s user 49m40.135s sys 6m14.466s after: real 1m10.397s user 49m43.849s sys 6m10.698s Running `./embuilder build libc --force`: before: real 0m5.597s user 3m2.721s sys 0m50.843s after: real 0m5.609s user 3m0.998s sys 0m49.796s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are plans underway to start using pathlib more in emscripten.
See: #14074
This change a designed to test the water by using
pathlibin testcode.
This allows us to use unix-like paths throughout the tests that will
get converted to windows-paths on windows machines automatically
by the pathlib library.
For example: