Skip to content

feat: drop support for older versions and modernize addon #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: drop support for older versions and modernize addon #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,22 @@ further details.

## Compatibility

- Ember Bootstrap v5
- Ember CP Validations v5
- Ember Bootstrap v5 or above
- Ember CP Validations v5 or above
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch. Do you mind extracting that change in a dedicated PR?

- Ember.js v3.28 or above
- Ember CLI v3.28 or above
- Node.js v20 or above

## Requirements

This addon requires the following minimum versions in the host application. It's recommended to install these (or newer) before installing this addon:

- ember-bootstrap: >= 5.0.0
- ember-cp-validations: >= 5.0.0
- ember-source (Ember.js): >= 3.28.0
- Ember CLI: >= 3.28.0
- Node.js: >= 20.0.0

## Installation

```
Expand Down
5 changes: 3 additions & 2 deletions ember-cli-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
module.exports = function (defaults) {
const app = new EmberAddon(defaults, {
'ember-bootstrap': {
bootstrapVersion: 4,
importBootstrapCSS: true,
bootstrapVersion: 5,
importBootstrapCSS: false,
insertEmberWormholeElementToDom: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing those two deprecations of Ember Bootstrap is a good thing. Do you mind extracting those in a separate PR?

Please ensure that the dummy app still renders as expected. Especially from styles perspective as it changes how CSS is imported and which version of Bootstrap is used.

},
});

Expand Down
13 changes: 9 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
},
"dependencies": {
"@babel/core": "^7.27.1",
"@ember/string": "4.0.1",
"ember-cli-babel": "^8.2.0",
"ember-cli-htmlbars": "^6.3.0",
"ember-template-imports": "^4.3.0"
Expand All @@ -47,7 +48,6 @@
"@babel/eslint-parser": "7.28.4",
"@babel/plugin-proposal-decorators": "7.28.0",
"@ember/optional-features": "2.2.0",
"@ember/string": "4.0.1",
"@ember/test-helpers": "5.3.0",
"@embroider/macros": "1.19.1",
"@embroider/test-setup": "4.0.0",
Expand All @@ -68,13 +68,13 @@
"ember-cli-sri": "2.1.1",
"ember-cli-terser": "4.0.2",
"ember-cp-validations": "7.0.0",
"ember-getowner-polyfill": "3.0.2",
"ember-load-initializers": "3.0.1",
"ember-page-title": "9.0.3",
"ember-qunit": "9.0.4",
"ember-resolver": "13.1.1",
"ember-source": "6.8.0",
"ember-source": "https://s3.amazonaws.com/builds.emberjs.com/release/shas/d4f3ecf4225f000e2fdcaf43eee80c819d0d9a9b.tgz",
"ember-source-channel-url": "3.0.0",
"ember-style-modifier": "^4.5.1",
"ember-template-lint": "7.9.3",
"ember-try": "4.0.0",
"eslint": "9.37.0",
Expand Down Expand Up @@ -125,5 +125,10 @@
"release": true,
"tokenRef": "GITHUB_AUTH"
}
},
"pnpm": {
"overrides": {
"ember-source": "$ember-source"
}
}
}
}
Loading