feat: drop support for older versions and modernize addon #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: - Drop support for ember-cp-validations < 5 - Drop support for ember-bootstrap < 5 - Drop support for Ember < 3.28 - Drop support for Node.js < 20 - Remove ember-getowner-polyfill (unnecessary for Ember 2.3+) Features: - Add peer dependencies to declare compatibility requirements - Update to Bootstrap 5 configuration - Add @ember/string dependency for Embroider compatibility - Upgrade ember-style-modifier to v4.5.1 for embroider-safe compatibility Fixes: - Fix Bootstrap CSS import deprecation warnings - Fix ember-bootstrap wormhole deprecation warnings - Fix Embroider build compatibility issues - Achieve 100% compatibility test matrix (10/10 scenarios passing) Documentation: - Update README with new requirements section - Add comprehensive compatibility information - Update minimum version specifications
|
I fear there was a misunderstanding. #226 is already fully implemented. Only release is pending due to a permission issue. |
jelhan
reviewed
Oct 16, 2025
| - Ember Bootstrap v5 | ||
| - Ember CP Validations v5 | ||
| - Ember Bootstrap v5 or above | ||
| - Ember CP Validations v5 or above |
There was a problem hiding this comment.
This is a good catch. Do you mind extracting that change in a dedicated PR?
| importBootstrapCSS: true, | ||
| bootstrapVersion: 5, | ||
| importBootstrapCSS: false, | ||
| insertEmberWormholeElementToDom: false, |
There was a problem hiding this comment.
Addressing those two deprecations of Ember Bootstrap is a good thing. Do you mind extracting those in a separate PR?
Please ensure that the dummy app still renders as expected. Especially from styles perspective as it changes how CSS is imported and which version of Bootstrap is used.
This was referenced Oct 16, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:#226
BREAKING CHANGES:
Features:
Fixes:
Documentation: