[ML] Remove impossible move constructor/assignment #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLeafNodeStatistics specified a default move constructor and move assignment operator. However, these cannot be generated because the class has a const reference member. They were not called anywhere, so this change removes the = default directives to avoid compiler warnings.
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Dec 2, 2019
CLeafNodeStatistics specified a default move constructor and move assignment operator. However, these cannot be generated because the class has a const reference member. They were not called anywhere, so this change removes the = default directives to avoid compiler warnings. Backport of elastic#866
droberts195
pushed a commit
that referenced
this pull request
Dec 2, 2019
CLeafNodeStatistics specified a default move constructor and move assignment operator. However, these cannot be generated because the class has a const reference member. They were not called anywhere, so this change removes the = default directives to avoid compiler warnings. Backport of #866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLeafNodeStatistics specified a default move constructor
and move assignment operator. However, these cannot be
generated because the class has a const reference member.
They were not called anywhere, so this change removes the
= default directives to avoid compiler warnings.