Skip to content

Commit 3ff88cc

Browse files
author
David Roberts
authored
[ML] Remove impossible move constructor/assignment (#866)
CLeafNodeStatistics specified a default move constructor and move assignment operator. However, these cannot be generated because the class has a const reference member. They were not called anywhere, so this change removes the = default directives to avoid compiler warnings.
1 parent 3ab04f6 commit 3ff88cc

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

include/maths/CBoostedTreeImpl.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,10 @@ class MATHS_EXPORT CBoostedTreeImpl final {
185185

186186
CLeafNodeStatistics(const CLeafNodeStatistics&) = delete;
187187

188-
CLeafNodeStatistics(CLeafNodeStatistics&&) = default;
188+
// Move construction/assignment not possible due to const reference member
189189

190190
CLeafNodeStatistics& operator=(const CLeafNodeStatistics&) = delete;
191191

192-
CLeafNodeStatistics& operator=(CLeafNodeStatistics&&) = default;
193-
194192
//! Apply the split defined by \p split.
195193
//!
196194
//! \return Shared pointers to the left and right child node statistics.

0 commit comments

Comments
 (0)