Add new configuration option for Elasticsearch path prefix #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
I've just read and signed the contributor agreement. Do I need to make a new pull request? |
|
@bryangwj Thanks for signing the CLA. Opening a new PR is not required. |
|
Closing and reopening to try to get the Buildkite CI job going. |
|
buildkite test this |
technige
pushed a commit
to technige/mcp-server-elasticsearch
that referenced
this pull request
Jun 6, 2025
* Update index.ts to accept path prefix in Elasticsearch URL * Update README.md to include information about path prefix --------- Co-authored-by: Josh Mock <[email protected]>
technige
added a commit
that referenced
this pull request
Jun 6, 2025
* Includes specific user-agent for MCP * Simplified product name for user agent * chore(deps): update node.js to v22.16.0 (#58) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> * Add new configuration option for Elasticsearch path prefix (#72) * Update index.ts to accept path prefix in Elasticsearch URL * Update README.md to include information about path prefix --------- Co-authored-by: Josh Mock <[email protected]> * fix(deps): update dependency @elastic/elasticsearch to v9.0.2 (#74) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> * chore(deps): update buildkite plugin monorepo-diff to v1.4.0 (#75) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> * fix(deps): update dependency @modelcontextprotocol/sdk to v1.12.1 (#76) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> --------- Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> Co-authored-by: Ang Wei Jun Bryan <[email protected]> Co-authored-by: Josh Mock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only configuration option for the Elasticsearch instance URL is
ES_URL. However, this means you cannot directly connect to Elasticsearch instances behind a reverse proxy or ingress controller that exposes Elasticsearch at a non-root path. This is because the current@elastic/elasticsearchJavaScript client internally uses theundiciHTTP library for Node.js, which enforces strict URL validation for connections. Specifically,undicidoes not allow paths other than/in the base URL you provide to the node property. If you try to connect to a URL likehttps://example.test.net/test-es/elastic, the client throws anInvalidArgumentError: invalid urlbecause the path is not/. The changes in this pull request addresses this issue by allowing users to include a path prefix (e.g./test-es/elastic) with theES_PATH_PREFIXconfiguration option, while ES_URL remains as before (e.g.https://example.test.net).