Includes specific user-agent for MCP #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No test suite yet exists for this project, but a quick local test with mitmproxy confirms that the correct header value is transmitted to a start-local server instance. |
JoshMock
approved these changes
May 23, 2025
Comment on lines
14
to
19
| // Product metadata, used to generate the request User-Agent header and | ||
| // passed to the McpServer constructor. | ||
| const product = { | ||
| name: "elasticsearch-mcp-server", | ||
| version: "0.1.1", | ||
| }; |
There was a problem hiding this comment.
Quick improvement so you don't have to remember to modify this file before every release.
Suggested change
| // Product metadata, used to generate the request User-Agent header and | |
| // passed to the McpServer constructor. | |
| const product = { | |
| name: "elasticsearch-mcp-server", | |
| version: "0.1.1", | |
| }; | |
| // Product metadata, used to generate the request User-Agent header and | |
| // passed to the McpServer constructor. | |
| const { version } = JSON.parse(fs.readFileSync('package.json')) | |
| const product = { | |
| name: "elasticsearch-mcp-server", | |
| version, | |
| }; |
There was a problem hiding this comment.
Good call, I actually wondered about this while I was writing it :)
jedrazb
approved these changes
May 26, 2025
|
buildkite test this |
|
buildkite test this |
Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
* Update index.ts to accept path prefix in Elasticsearch URL * Update README.md to include information about path prefix --------- Co-authored-by: Josh Mock <[email protected]>
…c#74) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
…astic#76) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
|
buildkite test this |
swallez
approved these changes
Jun 6, 2025
|
buildkite test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes in a specific user agent to identify traffic as originating from the MCP server. The product name and version has been extracted into a separate variable near the top of the script, and this is then used to both populate the User-Agent header and the McpServer object constructor.