Use ThreadedActionListener in ListenableFuture #94367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following elastic#94363 we can use `ThreadedActionListener` to represent the forking that happens within `ListenableFuture`, rather than tracking the executor and listener as separate components of a Tuple.
DaveCTurner
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
reviewed
Mar 7, 2023
| if (done) { | ||
| return false; | ||
| } | ||
| if (threadContext != null) { |
Member
There was a problem hiding this comment.
Minor: these operations could be done outside the lock. Not sure if there's enough contention here to make any difference though
Contributor
Author
There was a problem hiding this comment.
I think there isn't all that much contention here in practice, and it's been like this since it was introduced 4 years ago in #37327.
thecoop
approved these changes
Mar 7, 2023
Member
thecoop
left a comment
thecoop
left a comment
There was a problem hiding this comment.
LGTM, one minor ordering comment
Contributor
Author
|
@elasticmachine update branch |
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2023-03-07-ListenableFuture-using-ThreadedActionListener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #94363 we can use
ThreadedActionListenerto represent the forking that happens withinListenableFuture, rather than tracking the executor and listener as separate components of a Tuple.