Use rejection exception in ThreadedActionListener #94363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today if the exceptional completion of a `ThreadedActionListener` is rejected from its executor then the listener is completed with the original exception on the completing thread, with the exception representing the rejection added to its suppressed exceptions list. In practice this is a little trappy, we may want to handle the rejection differently but won't always remember to check the suppressed exceptions list for a rejection. This commit reverses the order of exceptions passed to the delegate listener in this case: the rejection exception is at the top level, with the original exception added to its suppressed exceptions list.
DaveCTurner
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
|
DaveCTurner
deleted the
2023-03-07-ThreadedActionListener-rejection-suppression
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 7, 2023
Following elastic#94363 we can use `ThreadedActionListener` to represent the forking that happens within `ListenableFuture`, rather than tracking the executor and listener as separate components of a Tuple.
DaveCTurner
added a commit
that referenced
this pull request
Mar 7, 2023
Following #94363 we can use `ThreadedActionListener` to represent the forking that happens within `ListenableFuture`, rather than tracking the executor and listener as separate components of a Tuple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if the exceptional completion of a
ThreadedActionListeneris rejected from its executor then the listener is completed with the original exception on the completing thread, with the exception representing the rejection added to its suppressed exceptions list. In practice this is a little trappy, we may want to handle the rejection differently but won't always remember to check the suppressed exceptions list for a rejection.This commit reverses the order of exceptions passed to the delegate listener in this case: the rejection exception is at the top level, with the original exception added to its suppressed exceptions list.