Fix ignored tests in the desired-balance feature branch #91305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
:Distributed Coordination/Allocation
idegtiarenko
changed the base branch from
main
to
feature/desired-balance-allocator
idegtiarenko
commented
Nov 4, 2022
| } | ||
|
|
||
| @AwaitsFix(bugUrl = "TODO") | ||
| public void testRestoreIndexWithShardsMissingInLocalGateway() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
Executed this 250 times. No failures so far
idegtiarenko
commented
Nov 4, 2022
| } | ||
|
|
||
| @AwaitsFix(bugUrl = "TODO") | ||
| public void testNoRebalanceOnRollingRestart() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
This test was broken as we were not detecting delayed shards as ignored
idegtiarenko
commented
Nov 4, 2022
| shardRouting -> Stream.of( | ||
| shardRouting, | ||
| shardRouting.updateUnassigned(discardAllocationStatus(shardRouting.unassignedInfo()), shardRouting.recoverySource()) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Related to #90600
In some cases the allocation status is coming from GatewayAllocator and need to be reseted to NO_ATTEMPT to be able to find the ignored shard in others (NO_VALID_SHARD_COPY) it is kept as is.
I wonder if this indicates that we want to have some other way of identifying ignored shards bypassing its entire state and unassigned info?
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.