Skip to content

Initialize shards assuming they would be placed on original nodes #90600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 4, 2022
Merged

Initialize shards assuming they would be placed on original nodes #90600

merged 9 commits into from
Oct 4, 2022

Conversation

@idegtiarenko
Copy link
Contributor

@idegtiarenko idegtiarenko commented Oct 3, 2022

No description provided.

@idegtiarenko idegtiarenko added :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Oct 3, 2022
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 3, 2022

Pinging @elastic/es-distributed (Team:Distributed)

idegtiarenko
idegtiarenko commented Oct 3, 2022
View reviewed changes
...main/java/org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceComputer.java Outdated
if (info != null
&& info.getLastAllocatedNodeId() != null
&& routingNodes.node(info.getLastAllocatedNodeId()) != null
&& ignoredShards.contains(shardRouting) == false) {
Copy link
Contributor Author

@idegtiarenko idegtiarenko Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do it even if shard is ignored?

Copy link
Contributor Author

@idegtiarenko idegtiarenko Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am writing a unit test for this

Copy link
Contributor

@DaveCTurner DaveCTurner Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only want to do this if a shard is ignored because that indicates the GatewayAllocator is still taking responsibility for it (and therefore we expect will eventually assign it). If the shard is not ignored then its last-allocated ID shouldn't be relevant, it's effectively a new shard and should be left for the delegate allocator.

DaveCTurner
DaveCTurner previously approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment nit.

...main/java/org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceComputer.java Outdated
if (info != null
&& info.getLastAllocatedNodeId() != null
&& routingNodes.node(info.getLastAllocatedNodeId()) != null
&& ignoredShards.contains(shardRouting) == false) {
Copy link
Contributor

@DaveCTurner DaveCTurner Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only want to do this if a shard is ignored because that indicates the GatewayAllocator is still taking responsibility for it (and therefore we expect will eventually assign it). If the shard is not ignored then its last-allocated ID shouldn't be relevant, it's effectively a new shard and should be left for the delegate allocator.

@DaveCTurner DaveCTurner dismissed their stale review October 3, 2022 13:32

this approach doesn't work

@DaveCTurner
Copy link
Contributor

DaveCTurner commented Oct 3, 2022

We discussed in another channel - this approach doesn't quite work because it might try and assign a replica before its primary. Instead we should incorporate the previous node ID into the targetNodes used when we're aligning things with the previous desired balance.

DaveCTurner
DaveCTurner approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@idegtiarenko idegtiarenko mentioned this pull request Oct 3, 2022
Closed
23 tasks
@idegtiarenko idegtiarenko merged commit bd2bbf0 into elastic:feature/desired-balance-allocator Oct 4, 2022
@idegtiarenko idegtiarenko deleted the fix_testSingleIndexStartedShard branch October 4, 2022 06:31
@idegtiarenko idegtiarenko mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@idegtiarenko @elasticsearchmachine @DaveCTurner