Enhance REST tests for moving_percentiles #90569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>test
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
This adds a few more tests to the REST layer tests for `moving_percentiles` in an effort to buy us forwards and backwards compatibility tests for all aggregations.
not-napoleon
approved these changes
Oct 19, 2022
|
|
||
| --- | ||
| "Basic Search HDR": | ||
| tdest: |
Member
There was a problem hiding this comment.
I don't love the shorter names. This one in particular, you need to know that the default algorithm for percentiles is t-digest already for it to make sense. I think a couple more words to spell this out would be good.
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few more tests to the REST layer tests for
moving_percentilesin an effort to buy us forwards and backwards compatibility tests for all aggregations.