Skip to content

Avoid expensive call to Span.fromContextOrNull(null) #89135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Avoid expensive call to Span.fromContextOrNull(null) #89135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions modules/apm/src/main/java/org/elasticsearch/tracing/apm/APMTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,47 +286,47 @@ private void setSpanAttributes(ThreadContext threadContext, @Nullable Map<String

@Override
public void addError(String spanId, Throwable throwable) {
final var span = Span.fromContextOrNull(spans.get(spanId));
final var span = spanFromContextOrNullWithoutLogging(spans.get(spanId));
if (span != null) {
span.recordException(throwable);
}
}

@Override
public void setAttribute(String spanId, String key, boolean value) {
final var span = Span.fromContextOrNull(spans.get(spanId));
final var span = spanFromContextOrNullWithoutLogging(spans.get(spanId));
if (span != null) {
span.setAttribute(key, value);
}
}

@Override
public void setAttribute(String spanId, String key, double value) {
final var span = Span.fromContextOrNull(spans.get(spanId));
final var span = spanFromContextOrNullWithoutLogging(spans.get(spanId));
if (span != null) {
span.setAttribute(key, value);
}
}

@Override
public void setAttribute(String spanId, String key, long value) {
final var span = Span.fromContextOrNull(spans.get(spanId));
final var span = spanFromContextOrNullWithoutLogging(spans.get(spanId));
if (span != null) {
span.setAttribute(key, value);
}
}

@Override
public void setAttribute(String spanId, String key, String value) {
final var span = Span.fromContextOrNull(spans.get(spanId));
final var span = spanFromContextOrNullWithoutLogging(spans.get(spanId));
if (span != null) {
span.setAttribute(key, value);
}
}

@Override
public void stopTrace(String spanId) {
final var span = Span.fromContextOrNull(spans.remove(spanId));
final var span = spanFromContextOrNullWithoutLogging(spans.remove(spanId));
if (span != null) {
logger.trace("Finishing trace [{}]", spanId);
span.end();
Expand All @@ -335,12 +335,18 @@ public void stopTrace(String spanId) {

@Override
public void addEvent(String spanId, String eventName) {
final var span = Span.fromContextOrNull(spans.get(spanId));
final var span = spanFromContextOrNullWithoutLogging(spans.get(spanId));
if (span != null) {
span.addEvent(eventName);
}
}

private static Span spanFromContextOrNullWithoutLogging(Context context) {
// Span.fromContextOrNull(null) is super-expensive today, see https://github.com/elastic/elasticsearch/issues/89107
// and https://github.com/open-telemetry/opentelemetry-java/pull/4663
return context == null ? null : Span.fromContextOrNull(context);
}

private static class MapKeyGetter implements TextMapGetter<Map<String, String>> {

@Override
Expand Down