Skip to content

Avoid expensive call to Span.fromContextOrNull(null) #89135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2022
Merged

Avoid expensive call to Span.fromContextOrNull(null) #89135

merged 1 commit into from
Aug 4, 2022

Conversation

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Aug 4, 2022

Workaround for #89107

@DaveCTurner DaveCTurner added >non-issue :Core/Infra/Core Core issues without another label v8.5.0 labels Aug 4, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Aug 4, 2022
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Aug 4, 2022

Pinging @elastic/es-core-infra (Team:Core/Infra)

ChrisHegarty
ChrisHegarty approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 4, 2022
@elasticsearchmachine elasticsearchmachine merged commit c08111b into elastic:main Aug 4, 2022
@DaveCTurner DaveCTurner deleted the 2022-08-04-cheaper-spanFromContextOrNull branch August 4, 2022 16:37
@ChrisHegarty ChrisHegarty mentioned this pull request Aug 10, 2022
Closed
@DaveCTurner DaveCTurner mentioned this pull request Aug 17, 2022
Closed
@pugnascotia pugnascotia mentioned this pull request Aug 17, 2022
Merged
elasticmachine pushed a commit to mushao999/elasticsearch that referenced this pull request Aug 18, 2022
@pugnascotia
Upgrade OpenTelemetry API and remove workaround (elastic#89438)
c541610 
Closes elastic#89414. Remove the workaround from elastic#89135 that addressed elastic#89107,
and instead upgrade the OpenTelemetry API, which contains a fix for the
underlying issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DaveCTurner @elasticsearchmachine @ChrisHegarty