Removing Blocking Wait for Close in RecoverySourceHandler #86127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the blocking wait when releasing safe commits or store references on the recovery source. This seems safe enough these days with elastic#85238 not tripping and the assertion that makes sure we never submit the close task to an already shut-down pool closes elastic#85839
original-brownbear
added
>bug
:Distributed Indexing/Engine
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
|
Hi @original-brownbear, I've created a changelog YAML for you. |
Contributor
Author
|
@DaveCTurner ++ to your comment in the original issue, I think fire and forget is fine here now. When I originally added the todo (and before that when this code was added) I believe we simply weren't in as clean a state as far as waiting for the recovery tasks up the stack on node shutdown and also didn't have the assertion that closing the store doesn't throw yet which might fire-and-forget not so great back in the day. |
Contributor
Author
|
Thanks David! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the blocking wait when releasing safe commits or store references on the recovery source.
This seems safe enough these days with #85238 not tripping
and the assertion that makes sure we never submit the close task to an already shut-down pool
Added the assertion to ensure no exception on close here since we already assert that the store closes without exception and neither should closing the commit ref.
closes #85839