Fail test if Node#awaitClose times out #85238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on nodes stopping gracefully in integ tests, rather than timing out and using `ThreadPool#shutdownNow` to ignore any remaining cleanup work. Today we throw an `IOException` if the shutdown wasn't graceful. With this commit we move to an `AssertionError` so we can be sure that any such problems result in a test failure. Relates elastic#85131
DaveCTurner
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
original-brownbear
approved these changes
Mar 22, 2022
DaveCTurner
added
the
auto-merge-without-approval
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 25, 2022
Remove the blocking wait when releasing safe commits or store references on the recovery source. This seems safe enough these days with elastic#85238 not tripping and the assertion that makes sure we never submit the close task to an already shut-down pool closes elastic#85839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on nodes stopping gracefully in integ tests, rather than timing
out and using
ThreadPool#shutdownNowto ignore any remaining cleanupwork. Today we throw an
IOExceptionif the shutdown wasn't graceful.With this commit we move to an
AssertionErrorso we can be sure thatany such problems result in a test failure.
Relates #85131