Skip to content

Remove invalid todo in ShardGetService #85921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Remove invalid todo in ShardGetService #85921

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b96aea7
remove invalid todo in ShardGetService
mushao999 Apr 15, 2022
dbb946f
Merge branch 'master' into remove_invalid_todo_in_ShardGetService
elasticmachine Apr 19, 2022
5535713
Merge branch 'master' into remove_invalid_todo_in_ShardGetService
mushao999 Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions server/src/main/java/org/elasticsearch/index/get/ShardGetService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,6 @@ private GetResult innerGetLoadFromStoredFields(
if (fetchSourceContext.fetchSource() == false) {
source = null;
} else if (fetchSourceContext.includes().length > 0 || fetchSourceContext.excludes().length > 0) {
// TODO: The source might be parsed and available in the sourceLookup but that one uses unordered maps so different.
// Do we care?
try {
source = XContentFieldFilter.newFieldFilter(fetchSourceContext.includes(), fetchSourceContext.excludes())
.apply(source, null);
Expand Down