Skip to content

Remove invalid todo in ShardGetService #85921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2022
Merged

Remove invalid todo in ShardGetService #85921

merged 3 commits into from
Apr 20, 2022

Conversation

@mushao999
Copy link
Contributor

@mushao999 mushao999 commented Apr 15, 2022 •
edited
Loading

668d557 added some todo in ShardGetService suggest that source might parsed and available in the sourceLookup.

elasticsearch/src/main/java/org/elasticsearch/index/get/ShardGetService.java

Line 315 in 668d557

// TODO: The source might parsed and available in the sourceLookup but that one uses unordered maps so different. Do we care?

elasticsearch/src/main/java/org/elasticsearch/index/get/ShardGetService.java

Line 431 in 668d557

// TODO: The source might parsed and available in the sourceLookup but that one uses unordered maps so different. Do we care?

However ,SourceLookup in ShardGetService has been remove in #20158 which made these todo invalid.
One of them has been removed in #83152
This PR remove the left invalid todo in ShardGetService

@elasticsearchmachine elasticsearchmachine added v8.3.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 15, 2022
@mushao999 mushao999 mentioned this pull request Apr 15, 2022
Merged
@javanna javanna added the :Search/Search Search-related issues that do not fall into other categories label Apr 19, 2022
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Apr 19, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 19, 2022

Pinging @elastic/es-search (Team:Search)

@javanna javanna added >non-issue and removed Team:Search Meta label for search team labels Apr 19, 2022
@javanna javanna requested a review from nik9000 April 19, 2022 14:19
@nik9000
Copy link
Member

nik9000 commented Apr 19, 2022

@javanna javanna assigned nik9000 34 minutes ago

❤️

@nik9000
Copy link
Member

nik9000 commented Apr 19, 2022

@elasticmchine, ok to test

@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 19, 2022
@nik9000
Copy link
Member

nik9000 commented Apr 19, 2022

@elasticmachine update branch

that test failure can't be caused by this

@nik9000
Copy link
Member

nik9000 commented Apr 19, 2022

that test failure can't be caused by this

maybe it's already fixed......

@elasticsearchmachine elasticsearchmachine merged commit 445d438 into elastic:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees

@nik9000 nik9000

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :Search/Search Search-related issues that do not fall into other categories v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mushao999 @elasticmachine @nik9000 @javanna @elasticsearchmachine