Skip to content

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Apr 11, 2022

The legacy node.ROLENAME settings were removed in 8.0 (#71163), but
machine dependent heap still handles them. This commit cleans up the
heap settings determination to no longer look for these legacy settings.

relates #85758

The legacy node.ROLENAME settings were removed in 8.0 (elastic#71163), but
machine dependent heap still handles them. This commit cleans up the
heap settings determination to no longer look for these legacy settings.

relates elastic#85758
@rjernst rjernst added :Core/Infra/Core Core issues without another label >refactoring v8.3.0 labels Apr 11, 2022
@rjernst rjernst requested a review from mark-vieira April 11, 2022 21:05
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Apr 11, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst changed the title Remove remaing references to legacy role settings Remove remaining references to legacy role settings Apr 11, 2022
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit 0d87edd into elastic:master Apr 11, 2022
@rjernst rjernst deleted the cli/machine_dep_heap_node_settings branch April 11, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants