Remove legacy role settings #71163
Merged
Remove legacy role settings #71163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the previously deprecated legacy role settings. These settings have been replaced by node.roles.
jasontedor
added
>breaking
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Apr 1, 2021
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
LGTM. Just a couple minor suggestions
| * `node.voting_only` | ||
| have been removed. Instead, use the `node.roles` setting. If you were previously | ||
| using the legacy role settings on 7.13 or later cluster, you will have a |
| have been removed. Instead, use the `node.roles` setting. If you were previously | ||
| using the legacy role settings on 7.13 or later cluster, you will have a | ||
| deprecation log message on each of your node informing you of the exact |
Member
There was a problem hiding this comment.
Maybe reword the last part of this:
on each of your nodes indicating the exact replacement value for node.roles.
| * Represents a node role. | ||
| */ | ||
| public abstract class DiscoveryNodeRole implements Comparable<DiscoveryNodeRole> { | ||
| public class DiscoveryNodeRole implements Comparable<DiscoveryNodeRole> { |
Member
There was a problem hiding this comment.
This could be a followup, but I wonder if we could make this final now. Seems like the only need for override is the enabled by default predicate, but this could be a lambda passed to the second constructor?
Member
Author
There was a problem hiding this comment.
Yeah, I will take a close look at opportunities for things like this when I get around to removing the plugin extension point for node roles.
jrodewig
added a commit
that referenced
this pull request
Sep 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 11, 2022
The legacy node.ROLENAME settings were removed in 8.0 (elastic#71163), but machine dependent heap still handles them. This commit cleans up the heap settings determination to no longer look for these legacy settings. relates elastic#85758
rjernst
added a commit
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the previously deprecated legacy role settings. These settings have been replaced by node.roles.
Relates #54998
Relates #71143
Closes #66409