Preserve context in ResultDeduplicator #84038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the `ResultDeduplicator` may complete a collection of listeners in contexts different from the ones in which they were submitted. This commit makes sure that the context is preserved in the listener.
DaveCTurner
added
>bug
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
Collaborator
|
Hi @DaveCTurner, I've updated the changelog YAML for you. |
…ithub.com:DaveCTurner/elasticsearch into 2022-02-16-preserve-context-in-ResultDeduplicator
jbaiera
approved these changes
Feb 16, 2022
Member
jbaiera
left a comment
jbaiera
left a comment
There was a problem hiding this comment.
LGTM from the ThreadContext side of things
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 17, 2022
Today the `ResultDeduplicator` may complete a collection of listeners in contexts different from the ones in which they were submitted. This commit makes sure that the context is preserved in the listener.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 17, 2022
Today the `ResultDeduplicator` may complete a collection of listeners in contexts different from the ones in which they were submitted. This commit makes sure that the context is preserved in the listener.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2022
DaveCTurner
deleted the
2022-02-16-preserve-context-in-ResultDeduplicator
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 17, 2022
In elastic#84038 we added a dependency on having a valid `threadContext` in a repository, but some tests use mocking and may end up with a `null` here. This seems not to be a problem in recent branches but causes failures in 8.0. With this commit we ensure that we always have a valid `threadContext` to avoid any problems.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2022
In #84038 we added a dependency on having a valid `threadContext` in a repository, but some tests use mocking and may end up with a `null` here. This seems not to be a problem in recent branches but causes failures in 8.0. With this commit we ensure that we always have a valid `threadContext` to avoid any problems.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 17, 2022
In elastic#84038 we added a dependency on having a valid `threadContext` in a repository, but some tests use mocking and may end up with a `null` here. This seems not to be a problem in recent branches but causes failures in 8.0. With this commit we ensure that we always have a valid `threadContext` to avoid any problems.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 17, 2022
Today the `ResultDeduplicator` may complete a collection of listeners in contexts different from the ones in which they were submitted. `snapshotDeletionListeners` has a similar problem. This commit makes sure that the context is preserved in these listeners. Backports elastic#84038, elastic#84089 and elastic#84093 to 8.0 - they could not be backported separately due to failures.
This was referenced Feb 17, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2022
In #84038 we added a dependency on having a valid `threadContext` in a repository, but some tests use mocking and may end up with a `null` here. This seems not to be a problem in recent branches but causes failures in 8.0. With this commit we ensure that we always have a valid `threadContext` to avoid any problems.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2022
…84100) Today the `ResultDeduplicator` may complete a collection of listeners in contexts different from the ones in which they were submitted. `snapshotDeletionListeners` has a similar problem. This commit makes sure that the context is preserved in these listeners. Backports #84038, #84089 and #84093 to 8.0 - they could not be backported separately due to failures.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 22, 2022
In elastic#83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in elastic#84038 and elastic#84089. With this commit we skip the new assertion in the known-buggy versions. Closes elastic#84036 again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2022
In #83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in #84038 and #84089. With this commit we skip the new assertion in the known-buggy versions. Closes #84036 again.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 22, 2022
In elastic#83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in elastic#84038 and elastic#84089. With this commit we skip the new assertion in the known-buggy versions. Closes elastic#84036 again.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 22, 2022
In elastic#83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in elastic#84038 and elastic#84089. With this commit we skip the new assertion in the known-buggy versions. Closes elastic#84036 again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2022
In #83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in #84038 and #84089. With this commit we skip the new assertion in the known-buggy versions. Closes #84036 again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2022
In #83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in #84038 and #84089. With this commit we skip the new assertion in the known-buggy versions. Closes #84036 again.
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
Today the `ResultDeduplicator` may complete a collection of listeners in contexts different from the ones in which they were submitted. This commit makes sure that the context is preserved in the listener.
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
In elastic#84038 we added a dependency on having a valid `threadContext` in a repository, but some tests use mocking and may end up with a `null` here. This seems not to be a problem in recent branches but causes failures in 8.0. With this commit we ensure that we always have a valid `threadContext` to avoid any problems.
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
In elastic#83290 we added an assertion that Elasticsearch returns the product header in every REST response. Unfortunately this isn't always the case, we found bugs in a couple of released versions and fixed them in elastic#84038 and elastic#84089. With this commit we skip the new assertion in the known-buggy versions. Closes elastic#84036 again.
arteam
pushed a commit
to arteam/elasticsearch
that referenced
this pull request
Jun 15, 2023
Today the `ResultDeduplicator` may complete a collection of listeners in contexts different from the ones in which they were submitted. This commit makes sure that the context is preserved in the listener.
arteam
added a commit
that referenced
this pull request
Jul 5, 2023
Today the `ResultDeduplicator` may complete a collection of listeners in contexts different from the ones in which they were submitted. This commit makes sure that the context is preserved in the listener. Co-authored-by: David Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the
ResultDeduplicatormay complete a collection of listeners incontexts different from the ones in which they were submitted. This
commit makes sure that the context is preserved in the listener.
Closes #84036